chore(ci): prevent duplicate ci triggers #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12681641455Details
💛 - Coveralls |
Triggering on all 'push' and 'pull_request' events will result in duplicated CI runs in PRs (due to both conditions being met). Instead, trigger only on pushes to `master`, or updates to PRs targetting `master`. Also removed cron job as all updates to `master` are checked anyway. Signed-off-by: JP-Ellis <josh@jpellis.me>
JP-Ellis
force-pushed
the
chore/prevent-duplicate-ci-triggers
branch
from
63d3054 to
753229d
Compare
tienvx
approved these changes
Jan 9, 2025
tienvx
reviewed
Jan 9, 2025
Comment on lines
-6
to
-8
| # Once on the first of the month at 06:00 UTC | ||
| schedule: | ||
| - cron: 0 6 1 * * |
There was a problem hiding this comment.
I think this code is for early detecting if any dependencies breaking the CI. I think we can remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Triggering on all 'push' and 'pull_request' events will result in duplicated CI runs in PRs (due to both conditions being met).
Instead, trigger only on pushes to
master, or updates to PRs targettingmaster.Also removed cron job as all updates to
masterare checked anyway.