Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI - Applied ruleset for master branch impacts release process #1372

Open
YOU54F opened this issue Feb 17, 2025 · 1 comment
Open

CI - Applied ruleset for master branch impacts release process #1372

YOU54F opened this issue Feb 17, 2025 · 1 comment

Comments

@YOU54F
Copy link
Member

YOU54F commented Feb 17, 2025

Similar to pact-foundation/pact_broker#779

package is created and pushed to npm.

updated version and changelog is expected to be pushed back, and release created, however new branch/ci restrictions impacts this from executing successfully

npm notice Publishing to https://registry.npmjs.org/ with tag latest and public access
+ @pact-foundation/pact@14.0.0
    done!
remote: error: GH013: Repository rule violations found for refs/heads/master.        
remote: Review all repository rules at https://github.com/pact-foundation/pact-js/rules?ref=refs%2Fheads%2Fmaster        
remote: 
remote: - Required status check "Test completion check" is expected.        
remote: 
To https://github.com/pact-foundation/pact-js
 * [new tag]           v14.0.0 -> v14.0.0
 ! [remote rejected]   master -> master (push declined due to repository rule violations)
error: failed to push some refs to 'https://github.com/pact-foundation/pact-js'

This has stopped

  • Updated package.json / lockfile from being committed back
  • Updated changelog from being committed back
  • A release from being created, with the appropriate changelog

furthermore, renovate auto-merged a PR after the release, meaning it's awkward to retrospectively update the changelog and version in a sequential manner.

Ideally the release workflow should work as before the new restrictions were applied, or the release workflow should be able to circumvent restrictions.

cc: @JP-Ellis

@JP-Ellis
Copy link
Contributor

Do you know which account is being used to push to master? The rules can be adjusted to exempt that user specifically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants