Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Check whether tokman is still needed #72

Closed
2 tasks
mfocko opened this issue Jul 25, 2024 · 0 comments · Fixed by packit/deployment#589
Closed
2 tasks

Check whether tokman is still needed #72

mfocko opened this issue Jul 25, 2024 · 0 comments · Fixed by packit/deployment#589
Labels
area/github Related to GitHub implementation. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.

Comments

@mfocko
Copy link
Member

mfocko commented Jul 25, 2024

As per the comment by Hunor on Feb 27 2023, the tokens are no longer invalidated when the new ones are requested.

TODO:

  • Check whether it's feasible to run without tokman in the previous setup
  • Based on the logs try to check how much it takes to query tokman for token vs request new token from GitHub yourself (from worker)
@mfocko mfocko added area/github Related to GitHub implementation. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related. labels Jul 25, 2024
@lbarcziova lbarcziova moved this from new to backlog in Packit Kanban Board Jul 25, 2024
@mfocko mfocko mentioned this issue Aug 1, 2024
Merged
1 task
mfocko added a commit to packit/deployment that referenced this issue Aug 2, 2024
@mfocko
fix: drop tokman deployment (#589)
e711a52 
* Drop deployment of tokman
* Mount GitHub App private key
* Adjust the variables in templates

<!-- TODO list -->

TODO:

- [x] Updated `extra-vars.yml` in Bitwarden

<!-- notes for reviewers -->

<!-- Links to other issues or pull requests,
for cross-repository links use: ‹namespace›/‹repository›#‹ID of issue›
       (‹namespace›/‹repository›!‹ID of PR› respectively)
-->

Fixes packit/tokman#72
@github-project-automation github-project-automation bot moved this from backlog to done in Packit Kanban Board Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/github Related to GitHub implementation. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/high This issue impacts multiple/lot of users. kind/internal Doesn't affect users directly, may be e.g. infrastructure, DB related.
Projects
Packit Kanban Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: drop tokman deployment mfocko/deployment
1 participant
@mfocko