Merge pull request #114 from packbackbooks/fix-bug

packbackbooks · Nov 29, 2023 · f6a7fd8 · f6a7fd8
2 parents d8072aa + f1a8653
commit f6a7fd8
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/LtiAssignmentsGradesService.php b/src/LtiAssignmentsGradesService.php
@@ -192,7 +192,7 @@ private function isMatchingLineitem(array $lineitem, LtiLineitem $newLineItem):
 
     private function appendLineItemPath(LtiLineitem $lineItem, string $suffix): string
     {
-        $url = $lineitem->getId();
+        $url = $lineItem->getId();
         $pos = strpos($url, '?');
 
         if ($pos === false) {

diff --git a/src/LtiServiceConnector.php b/src/LtiServiceConnector.php
@@ -192,7 +192,7 @@ public static function getLogMessage(
             'request_method' => $request->getMethod(),
             'request_url' => $request->getUrl(),
             'response_headers' => $responseHeaders,
-            'response_body' => json_encode($responseBody),
+            'response_body' => $responseBody,
         ];
 
         $requestBody = $request->getPayload()['body'] ?? null;

diff --git a/tests/LtiServiceConnectorTest.php b/tests/LtiServiceConnectorTest.php
@@ -340,7 +340,7 @@ public function testItBuildsLogMessage()
 
         $result = $this->connector::getLogMessage($this->request, ['foo' => 'bar'], ['baz' => 'bat']);
 
-        $expected = "Logging request data: id {\"request_method\":\"POST\",\"request_url\":\"https:\/\/example.com\",\"response_headers\":{\"foo\":\"bar\"},\"response_body\":\"{\\\"baz\\\":\\\"bat\\\"}\",\"request_body\":\"{\\\"userId\\\":\\\"id\\\"}\"}";
+        $expected = "Logging request data: id {\"request_method\":\"POST\",\"request_url\":\"https:\/\/example.com\",\"response_headers\":{\"foo\":\"bar\"},\"response_body\":{\"baz\":\"bat\"},\"request_body\":\"{\\\"userId\\\":\\\"id\\\"}\"}";
 
         $this->assertEquals($expected, $result);
     }
@@ -355,7 +355,7 @@ public function testItMasksSensitiveDataInLogMessage()
 
         $result = $this->connector::getLogMessage($this->request, ['foo' => 'bar'], ['baz' => 'bat']);
 
-        $expected = "Logging request data: id {\"request_method\":\"POST\",\"request_url\":\"https:\/\/example.com\",\"response_headers\":{\"foo\":\"***\"},\"response_body\":\"{\\\"baz\\\":\\\"***\\\"}\",\"request_body\":\"{\\\"userId\\\":\\\"id\\\"}\"}";
+        $expected = "Logging request data: id {\"request_method\":\"POST\",\"request_url\":\"https:\/\/example.com\",\"response_headers\":{\"foo\":\"***\"},\"response_body\":{\"baz\":\"***\"},\"request_body\":\"{\\\"userId\\\":\\\"id\\\"}\"}";
 
         $this->assertEquals($expected, $result);
     }