Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin "pywinpty" to v0.5.7 #33

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kaste
Copy link

@kaste kaste commented Dec 16, 2024

pywinpty dropped support for python 3.8 but all current versions have important issues.

I manually downgraded to test if Terminus works with the old version, and looks like it does.

pywinpty dropped support for python 3.8 but all current versions have
important issues.

- andfoy/pywinpty#463
- andfoy/pywinpty#484
- andfoy/pywinpty#483
@kaste
Copy link
Author

kaste commented Dec 16, 2024

Just dropping it here; I don't know if this is the correct way of doing a version freeze.

@FichteFoll
Copy link
Member

Seeing how @deathaxe already investigated this in sublimehq/sublime_text#6550, I'll leave this for him to handle.

@deathaxe
Copy link
Collaborator

deathaxe commented Dec 22, 2024

As PC doesn't downgrade installed packages/libraries, nobody who has pywinpty dependency installed already would be affected.

Beyound loosing focus when starting a terminus session for the first time, there are no obvious negative effects besides increasing amount of conhosts sitting around.

Hence I actually don't see much value in pinning it to a decade old release.

Let's see if issue gets fixed upstream.

Currently there are no py38 incompatible changes in latest release, they just dropped creating wheels. Thats easy to fix.

@kaste
Copy link
Author

kaste commented Dec 22, 2024

The 100ms delay per keypress makes Terminus completely unusable or at least makes it feel completely broken. As a new user I think you would likely just uninstall Terminus.

@deathaxe
Copy link
Collaborator

Delay? In which condition? I don't see any on Win11

@kaste
Copy link
Author

kaste commented Dec 23, 2024

I had a lag between keypress and the character appearing on the screen. That was also reported on the original Terminus issue. (Very noticeable with ipython.) A search showed the 100ms issue I linked above immediately, so I stopped further investigations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants