Bug/fix srd eff value #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the UTXO value exceeds i64 max, the effective_value returns None causing the SRD algorithem to exit early. Instead, if effective_value returns None, discard that UTXO and continue.
yancyribbens
force-pushed
the
bug/fix-srd-eff-value
branch
from
8af14b8 to
f46622a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the UTXO value exceeds i64 max, the effective_value returns None causing the SRD algorithm to exit early. Instead, if effective_value returns None, discard that UTXO and continue.
This PR also contains a refactor to the SRD test module and minor refactor to SRD algo along with a version bump for release.