Skip to content
This repository has been archived by the owner on Apr 20, 2023. It is now read-only.

Parse URLs without trailing slash correctly. #191

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johanneswuerbach
Copy link

URLs like http://myurl.com?param=1 as origin weren't parsed properly.

@waltersaegir
Copy link

I see this failing:
if (/^file/.test(url)) {
throw new Error("The file:// protocol is not supported");
This is at a time when url: "file:///C:/Program%20Files%20(x86)/Apache%20Group/Apache2/htdocs/crossdomConsumer.html

It occurs on the first test of the first sample code.

@oyvindkinsey
Copy link
Owner

Don't use file://.
On Oct 7, 2012 11:44 PM, "Walter" notifications@github.com wrote:

I see this failing:
if (/^file/.test(url)) {
throw new Error("The file:// protocol is not supported");
This is at a time when url:
"file:///C:/Program%20Files%20(x86)/Apache%20Group/Apache2/htdocs/crossdomConsumer.html

It occurs on the first test of the first sample code.


Reply to this email directly or view it on GitHubhttps://github.com//pull/191#issuecomment-9217519.

@waltersaegir
Copy link

Good! I used http://localhost instead of doubleclicking on the html file and now I see no errors,
but I get no results.

@oyvindkinsey oyvindkinsey force-pushed the master branch 3 times, most recently from 4e46f32 to 2769b63 Compare April 8, 2019 17:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants