-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Light Dark mode and color themes. #99
Conversation
Great work adding this in! I have a small nitpick, I think the default theme should be set to auto. Even if the color scheme doesn't align well with the light theme, it is an option and should be what the app's theme is by default if the user's device is not in dark mode. |
2b97024
to
156afba
Compare
…the app based off a single seed color at minimum. Remove Type.kt to use M3 typography. Remove default project colors.
Yeah, youre right I suppose. Since the scope of this PR is around themeing, I commited an update to bring in MaterialKolor which is a nice library to theme the app based of a single seed color at minimum. This should help light/dark blend nicely without manually creating every single color for M3 tokens. There may be a few hard coded colors around the UI code. I'll go through that to make some objects more plesant. Light theme on the friends list is pretty bad. Hence my intial reasoning to go dark in the first place. |
Okay. I think most of the colors should be nicer in both dark and light mode. Also implemented some M3 guidelines for lists items, by adding horizontal dividers between items. |
Great work! |
Adds the option for the user to manually choose the theme settings on the fly. Choosing betweem Day, Night, or Auto (System).
Default state is now dark mode, just because the current color scheme doesnt align well with light theme.