Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light Dark mode and color themes. #99

Merged
merged 9 commits into from
Jan 26, 2025
Merged

Light Dark mode and color themes. #99

merged 9 commits into from
Jan 26, 2025

Conversation

LossyDragon
Copy link
Collaborator

Adds the option for the user to manually choose the theme settings on the fly. Choosing betweem Day, Night, or Auto (System).

Default state is now dark mode, just because the current color scheme doesnt align well with light theme.

@oxters168
Copy link
Owner

Great work adding this in! I have a small nitpick, I think the default theme should be set to auto. Even if the color scheme doesn't align well with the light theme, it is an option and should be what the app's theme is by default if the user's device is not in dark mode.

…the app based off a single seed color at minimum.

Remove Type.kt to use M3 typography.
Remove default project colors.
@LossyDragon
Copy link
Collaborator Author

LossyDragon commented Jan 25, 2025

Yeah, youre right I suppose. Since the scope of this PR is around themeing, I commited an update to bring in MaterialKolor which is a nice library to theme the app based of a single seed color at minimum. This should help light/dark blend nicely without manually creating every single color for M3 tokens.

There may be a few hard coded colors around the UI code. I'll go through that to make some objects more plesant.

Light theme on the friends list is pretty bad. Hence my intial reasoning to go dark in the first place.

@LossyDragon LossyDragon changed the title Add option for manual theme settings Light Dark mode and color themes. Jan 25, 2025
@LossyDragon LossyDragon requested a review from oxters168 January 26, 2025 05:16
@LossyDragon
Copy link
Collaborator Author

Okay. I think most of the colors should be nicer in both dark and light mode.

Also implemented some M3 guidelines for lists items, by adding horizontal dividers between items.

@oxters168
Copy link
Owner

Great work!

@oxters168 oxters168 merged commit 7566981 into master Jan 26, 2025
1 check passed
@LossyDragon LossyDragon deleted the day-night-theming branch January 26, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants