Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding fixes #158

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Padding fixes #158

merged 2 commits into from
Feb 19, 2025

Conversation

LossyDragon
Copy link
Collaborator

This PR fixes a couple of padding & layout issues.

  • Properly fix the hotfix from 1.3.1 for devices with display cutouts. The library list items should be able to scroll beneath the search bar, but disappear when it touches the status bar.
  • Fix library list items not filling their entire width when in landscape.
  • Fix friend list items not filling their entire width when in landscape.
  • Init preferences in previews, allowing them to show up in AS.

This can be tested by adding Modifier.border(1.dp, Color.Red) on composables that fill the screen.

@LossyDragon
Implement a proper fix for library list content padding. This usually…
d35ae01 
… affected devices with a display cutout.

Fix library items not filling width when in landscape.
Fix previews
@LossyDragon
Fix friend list items not filling width when in landscape.
1c71418
@oxters168
Copy link
Owner

Great work!

@oxters168 oxters168 merged commit 186d4d2 into master Feb 19, 2025
1 check passed
@oxters168 oxters168 deleted the padding-fixes branch February 19, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LossyDragon @oxters168