[sled-agent] Integrate config-reconciler

[jgallagher]

This PR integrates the new sled-agent-config-reconciler crate with sled-agent. It will not currently pass tests due to the reconciler not being completely implemented, but I'd like to get any feedback on this integration work itself (particularly as it pertains to the API of sled-agent-config-reconciler). See the description of #8063 for more context.

There are a couple serious warts with this PR:

• The inventory system has not been updated with all the details we need to report for the reconciler. This is a bigger chunk of work because it involves a database migration and touches various bits of Nexus, so I'll do that in a separate PR.
• This integration removes most uses of the StorageManager (because its functionality is being absorbed into sled-agent-config-reconciler); however, the storage manager also has a rich set of test support. This PR leaves a couple sled-agent submodules using that test support (support-bundle/storage and zone-bundle). In the long run I think it'd be better to rework these (if there are no remaining production uses of StorageManager), but for now I think this is... okay? Feedback welcome.

[smklein]

Are you expecting that inventory will supplant this info? Or are you planning on replacing this access to the sled agent later?

[jgallagher]

I was expecting that inventory would supplant this. (I think maybe it already has, in practice? I definitely only look at inventory when I'm curious about zpools; I don't think I've ever used these omdb subcommands.)

[smklein]

super-nit, link to PR, so this comment doesn't get lost?

[jgallagher]

PR isn't open yet, so hard to link. 😅 However, I put a stub in RSS on this branch where we need the updated inventory:

omicron/sled-agent/src/rack_setup/service.rs

Lines 426 to 434 in abd7542

	// Wait until the config reconciler on the target sled has successfully
	// reconciled the config at `generation`.
	async fn wait_for_config_reconciliation_on_sled(
	&self,
	_sled_address: SocketAddrV6,
	_generation: Generation,
	) -> Result<(), SetupServiceError> {
	unimplemented!("needs updated inventory")
	}

which guarantees this PR can't pass the helios/deploy check until the inventory work is done.

[smklein]

We're deleting a lot of tests here - do we really not care about these anymore, or do we have coverage elsewehre?

[jgallagher]

Little of column a, little of column b:

• All the methods these tests are exercising have themselves been deleted, so we're forced to remove these tests too.
• The functionality we've removed here will live in the config-reconciler now, but the tests won't port over 1-to-1 because the mechanics are changing (e.g., ledgering is largely independent from starting zones now, which is very different from how ensure_all_omicron_zones_persistent() worked). The reconciler will have its own tests for the new mechanics that cover this same functionality.