Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: save/load optimizer state #190

Merged
merged 6 commits into from
Feb 3, 2025
Merged

refactor: save/load optimizer state #190

merged 6 commits into from
Feb 3, 2025

Conversation

minghuaw
Copy link
Collaborator

@minghuaw minghuaw commented Jan 30, 2025 •
edited
Loading

Closes #187.

@minghuaw minghuaw marked this pull request as draft January 30, 2025 23:47
@minghuaw minghuaw changed the title refactor: add optimizer state functions refactor: save/load optimizer state Jan 31, 2025
@minghuaw minghuaw force-pushed the refactor/optimizer-state-io branch from 5cd141f to 4b3cd20 Compare January 31, 2025 08:38
@minghuaw minghuaw force-pushed the refactor/optimizer-state-io branch from a756ff0 to d1733ee Compare February 2, 2025 01:20
@minghuaw minghuaw marked this pull request as ready for review February 3, 2025 00:12
@minghuaw minghuaw requested a review from dcvz February 3, 2025 00:12
dcvz
dcvz approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@dcvz dcvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@minghuaw minghuaw merged commit 99e345d into main Feb 3, 2025
3 checks passed
@minghuaw minghuaw deleted the refactor/optimizer-state-io branch February 3, 2025 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcvz dcvz dcvz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built-in support for saving/loading optimizer state in safetensors format
2 participants
@minghuaw @dcvz