refactor(codegen): simplify printing comments between arguments in call-like expressions #9501

Dunqing · 2025-03-03T10:34:31Z

No description provided.

Dunqing · 2025-03-03T10:34:54Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

codspeed-hq · 2025-03-03T10:44:58Z

CodSpeed Performance Report

Merging #9501 will create unknown performance changes

_{Comparing 03-03-refactor_codegen_simplify_printing_annotation_comments (19c4835) with main (75f06ad)}

Summary

🆕 33 new benchmarks

Benchmarks breakdown

	Benchmark	`BASE`	`HEAD`	Change
🆕	`codegen[checker.ts]`	N/A	23.1 ms	N/A
🆕	`codegen_sourcemap[checker.ts]`	N/A	66.2 ms	N/A
🆕	`isolated-declarations[vue-id.ts]`	N/A	57.9 ms	N/A
🆕	`lexer[RadixUIAdoptionSection.jsx]`	N/A	20.9 µs	N/A
🆕	`lexer[antd.js]`	N/A	24.1 ms	N/A
🆕	`lexer[cal.com.tsx]`	N/A	5.7 ms	N/A
🆕	`lexer[checker.ts]`	N/A	14.5 ms	N/A
🆕	`lexer[pdf.mjs]`	N/A	3.8 ms	N/A
🆕	`linter[RadixUIAdoptionSection.jsx]`	N/A	2.7 ms	N/A
🆕	`linter[cal.com.tsx]`	N/A	1.2 s	N/A
🆕	`linter[checker.ts]`	N/A	2.9 s	N/A
🆕	`mangler[antd.js]`	N/A	16.1 ms	N/A
🆕	`mangler[react.development.js]`	N/A	297.6 µs	N/A
🆕	`mangler[typescript.js]`	N/A	39.8 ms	N/A
🆕	`minifier[antd.js]`	N/A	163.1 ms	N/A
🆕	`minifier[react.development.js]`	N/A	1.8 ms	N/A
🆕	`minifier[typescript.js]`	N/A	285.9 ms	N/A
🆕	`estree[checker.ts]`	N/A	91.8 ms	N/A
🆕	`parser[RadixUIAdoptionSection.jsx]`	N/A	88.7 µs	N/A
🆕	`parser[antd.js]`	N/A	111.4 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Boshen · 2025-03-03T11:55:25Z

Hold on, I'm doing a huge refactor ...

Boshen · 2025-03-04T00:14:16Z

Merge activity

Mar 3, 7:14 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Mar 3, 7:14 PM EST: A user added this pull request to the Graphite merge queue.
Mar 3, 7:22 PM EST: A user merged this pull request with the Graphite merge queue.

…ll-like expressions (#9501)

## [0.54.0] - 2025-03-04 - 098f652 codegen: [**BREAKING**] Add `CommentAnnotation` to avoid parsing comments again (#9506) (Boshen) - a8d1d48 parser,codegen: [**BREAKING**] Parse and print`#__NO_SIDE_EFFECTS__` (#9496) (Boshen) - 355a4db napi/parser: [**BREAKING**] Remove `parse_without_return` API (#9455) (Boshen) - a5cde10 visit_ast: [**BREAKING**] Add `oxc_visit_ast` crate (#9428) (Boshen) - abb15e0 ast: [**BREAKING**] Add `pure` field to `Function`, `CallExpression`, and `NewExpression` (#9207) (overlookmotel) ### Features - a9f0d2b ast_tools: Generate field offset assertions for more types (#9449) (overlookmotel) - 64f4a82 ecmascript: Handle pure call expression in chain expressions (#9480) (sapphi-red) - 32139d2 ecmascript: Support `/* @__PURE__ */` in may_have_side_effects (#9409) (sapphi-red) - f5453f6 minifier: Flatten spread args in new expressions (#9512) (sapphi-red) - f8073f3 minifier: Support if with side effects in dead code elimination (#9502) (sapphi-red) - 10eb8f7 minifier: Use `remove_unused_expression` in `try_fold_sequence_expression` in `remove_dead_code` (#9467) (sapphi-red) - 70916db minifier: Remove unused expression in for init and update (#9466) (sapphi-red) - 26fde56 minifier: Inline simple IIFEs in `remove_unused_expression` (#9465) (sapphi-red) - ec2193e minifier: Support extracting arguments in pure calls in `remove_unused_expression` (#9463) (sapphi-red) - 007051c minifier: Compress `a != null && a.b()` to `a?.b()` in `remove_unused_expression` (#9459) (sapphi-red) - 50fce20 minifier: Support binary expression in `remove_unused_expression` (#9456) (sapphi-red) - ed9ede3 minifier: Support conditional expression in `remove_unused_expression` (#9432) (sapphi-red) - 3520538 minifier: Support object expression in `remove_unused_expression` (#9430) (sapphi-red) - fb8a93d minifier: Improve array expression handling in `remove_unused_expression` (#9427) (sapphi-red) - ff477cd minifier: Support template literals in `remove_unused_expression` (#9426) (sapphi-red) - 0d26113 minifier: Compress `/* @__PURE__ */ a() ? b : b` to `b` (#9410) (sapphi-red) - 68c77c8 napi/parser: Return semantic errors (#9460) (Boshen) - 7d7f16c parser: Apply pure to rhs of binary expression (#9492) (Boshen) - 2a08b14 parser: Support V8 intrinsics (#9379) (injuly) - 9b7017c parser,codegen: Pure annotations (#9351) (Boshen) - aa06932 transformer: Support `ModuleRunnerTransform` (#9371) (Dunqing) ### Bug Fixes - 75f06ad codegen: Do not print comments when only `annotation_comments` is enabled (#9518) (Dunqing) - f5bbd5d ecmascript: Fix toString for negative numbers (#9508) (sapphi-red) - d2cd975 ecmascript: Fix may_have_side_effects for `${a() === b}` (#9478) (sapphi-red) - 584d847 ecmascript: Objects passed to template literals may have side effects (#9425) (sapphi-red) - b371fdc estree/ast: Camel-case `typeAnnotation` field (#9420) (overlookmotel) - 1fff993 minifier: Correctly remove dead code in `try` with `finally` (#9503) (sapphi-red) - 0b96ebe minifier: Don't inline IIFE with parameters (#9477) (sapphi-red) - 071c84c minifier: Skip `try_fold_stmt_in_boolean_context` on `ExpressionStatement` (#9458) (sapphi-red) - 306284d minifier: Call mark_current_function_as_changed in remove_unused_expression (#9457) (sapphi-red) - 9c6ae9f parser: `@__NO_SIDE_EFFECTS` only affects const variable decl (#9517) (Boshen) - b7d5513 parser: Parse `@__NO_SIDE_EFFECTS__` between `export default` and `async function` (#9514) (Boshen) - 01de74c parser: Correctly fail parsing when parsing `foo.bar?.` (#9499) (camc314) - 58defe3 parser: Mark expression as pure in chain expression (#9479) (sapphi-red) - 2a03689 parser: Mark expressions on the left side of logical and conditional expressions as pure (#9414) (sapphi-red) - 7fde233 transformer/legacy-decorator: Incorrect check for potentially non-existent ident (#9491) (Dunqing) - b4f050c transformer/legacy-decorator: Metadata incorrectly wrapped by decorateParam (#9490) (Dunqing) - 5f67fa9 transformer/optional-chaning: Keep `this` when transforming `this.f?.()` (#9505) (camc314) ### Performance - 10e4431 ast/estree: Skip escaping identifiers (#9398) (overlookmotel) - b0a0a82 ast/estree: Reduce overhead serializing static strings (#9396) (overlookmotel) - 27a8e50 isolated_declarations: Reserve sufficient capacity in statements `Vec` (#9394) (overlookmotel) ### Refactor - 8916335 ast/estree: Convert enums with converters on variants (#9438) (overlookmotel) - dcff40c ast_tools: Generate layout assertions in multiple crates (#9448) (overlookmotel) - 19c4835 codegen: Simplify printing comments between arguments in call-like expressions (#9501) (Dunqing) - c880481 isolated_declarations: Rename var (#9390) (overlookmotel) - 37e41f0 isolated_declarations: Use aliases `ArenaBox` / `ArenaVec` (#9389) (overlookmotel) - bbb450c minifier: Move `a != null && b` -> `a ?? b` compression to `remove_unused_expression` (#9468) (sapphi-red) - b93774c minifier: Move `try_fold_iife` to `remove_unused_expression` (#9464) (sapphi-red) - 96a9719 minifier: Use `may_have_side_effects` in `remove_unused_expression` (#9413) (sapphi-red) ### Testing - c187b11 ecmascript: Add comments and tests for cases where `ToPropertyKey` throws an error (#9429) (sapphi-red) - d129055 napi: Add tests for worker threads (#9408) (Boshen) - 48d51e3 napi: Add tests for `hashbang` field (#9386) (overlookmotel) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>

github-actions bot added A-codegen Area - Code Generation C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Mar 3, 2025

Boshen marked this pull request as draft March 3, 2025 11:55

Dunqing changed the base branch from main to graphite-base/9501 March 3, 2025 16:15

Dunqing force-pushed the 03-03-refactor_codegen_simplify_printing_annotation_comments branch from 80309aa to 6dccb75 Compare March 3, 2025 16:15

Dunqing changed the base branch from graphite-base/9501 to 03-04-fix_codegen_do_not_print_comments_when_only_annotation_comments_is_enabled March 3, 2025 16:15

Dunqing mentioned this pull request Mar 3, 2025

fix(codegen): do not print comments when only annotation_comments is enabled #9518

Merged

Dunqing marked this pull request as ready for review March 3, 2025 16:15

Boshen added the 0-merge Merge with Graphite Merge Queue label Mar 4, 2025

refactor(codegen): simplify printing comments between arguments in ca…

19c4835

…ll-like expressions (#9501)

graphite-app bot force-pushed the 03-04-fix_codegen_do_not_print_comments_when_only_annotation_comments_is_enabled branch from 805c751 to 75f06ad Compare March 4, 2025 00:14

graphite-app bot force-pushed the 03-03-refactor_codegen_simplify_printing_annotation_comments branch from 6dccb75 to 19c4835 Compare March 4, 2025 00:15

Base automatically changed from 03-04-fix_codegen_do_not_print_comments_when_only_annotation_comments_is_enabled to main March 4, 2025 00:19

graphite-app bot merged commit 19c4835 into main Mar 4, 2025
27 checks passed

graphite-app bot deleted the 03-03-refactor_codegen_simplify_printing_annotation_comments branch March 4, 2025 00:22

oxc-bot mentioned this pull request Mar 4, 2025

release(crates): v0.54.0 #9524

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor(codegen): simplify printing comments between arguments in call-like expressions #9501

refactor(codegen): simplify printing comments between arguments in call-like expressions #9501

Dunqing commented Mar 3, 2025

Dunqing commented Mar 3, 2025 •

edited

Loading

codspeed-hq bot commented Mar 3, 2025 •

edited

Loading

Boshen commented Mar 3, 2025

Boshen commented Mar 4, 2025 •

edited by graphite-app bot

Loading

refactor(codegen): simplify printing comments between arguments in call-like expressions #9501

refactor(codegen): simplify printing comments between arguments in call-like expressions #9501

Conversation

Dunqing commented Mar 3, 2025

Dunqing commented Mar 3, 2025 • edited Loading

How to use the Graphite Merge Queue

codspeed-hq bot commented Mar 3, 2025 • edited Loading

CodSpeed Performance Report

Merging #9501 will create unknown performance changes

Summary

Benchmarks breakdown

Boshen commented Mar 3, 2025

Boshen commented Mar 4, 2025 • edited by graphite-app bot Loading

Merge activity

Dunqing commented Mar 3, 2025 •

edited

Loading

codspeed-hq bot commented Mar 3, 2025 •

edited

Loading

Boshen commented Mar 4, 2025 •

edited by graphite-app bot

Loading