ci(benchmarks): exclude parser from isolated declarations benchmark timing #9388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Feb 26, 2025
|
In case anyone wonders, the reason I was looking at isolated declarations was the surprising benchmark result on #9301. |
CodSpeed Performance ReportMerging #9388 will improve performances by ×13Comparing Summary
Benchmarks breakdown
|
This was referenced Feb 26, 2025
Merge activity
|
…iming (#9388) Similar to other benchmarks, in benchmark for isolated declarations, only time the component under test - the actual generation of isolated declarations file. Previously, the benchmark also included parsing. This removes a source of variance from the benchmark and "zooms in" on performance of the thing itself. It'll be easier to see improvements/degradations in performance.
graphite-app
bot
force-pushed
the
02-23-ci_benchmarks_exclude_parser_from_isolated_declarations_benchmark_timing
branch
from
a925498 to
551654e
Compare
graphite-app
bot
deleted the
02-23-ci_benchmarks_exclude_parser_from_isolated_declarations_benchmark_timing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to other benchmarks, in benchmark for isolated declarations, only time the component under test - the actual generation of isolated declarations file. Previously, the benchmark also included parsing.
This removes a source of variance from the benchmark and "zooms in" on performance of the thing itself. It'll be easier to see improvements/degradations in performance.