perf(data_structures, ast/estree): add CodeBuffer::print_bytes_iter_unchecked method and use it in ESTree serializer

[overlookmotel]

Optimization to ESTree serialization. Avoid allocating a String when generating indentation, and use a "trusted length" iterator instead.

This only affects generation of pretty-printed JSON, so won't show on our benchmarks, which only use compact JSON form.

[overlookmotel]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• perf(data_structures, ast/estree): add CodeBuffer::print_bytes_iter_unchecked method and use it in ESTree serializer #9335 👈 (View in Graphite)
• refactor(data_structures): CodeBuffer::print_str use Vec::extend_from_slice #9332 : 1 other dependent PR (#9336 )
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #9335 will not alter performance

_{Comparing 02-24-perf_data_structures_ast_estree_add_codebuffer_print_bytes_iter_unchecked_method_and_use_it_in_estree_serializer (207ce35) with 02-23-refactor_data_structures_codebuffer_print_str_use_vec_extend_from_slice_ (2683394)}

Summary

✅ 33 untouched benchmarks

[overlookmotel]

Superceded by #9337 and #9331.