Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(allocator, linter): shorten serde impls #9254

Merged

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 20, 2025

Some of these impls were excessively verbose. Shorten them.

Also delete a file of dead code from oxc_allocator.

@github-actions github-actions bot added A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 20, 2025
Copy link
Contributor Author

overlookmotel commented Feb 20, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

graphite-app bot commented Feb 20, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request Feb 20, 2025
Some of these impls were excessively verbose. Shorten them.

Also delete a file of dead code from `oxc_allocator`.
@graphite-app graphite-app bot force-pushed the 02-20-refactor_allocator_linter_shorten_serde_impls branch from e8c9bc8 to de35afb Compare February 20, 2025 02:19
@overlookmotel overlookmotel force-pushed the 02-20-refactor_allocator_linter_shorten_serde_impls branch from de35afb to e8c9bc8 Compare February 20, 2025 02:26
Some of these impls were excessively verbose. Shorten them.

Also delete a file of dead code from `oxc_allocator`.
@graphite-app graphite-app bot force-pushed the 02-20-refactor_allocator_linter_shorten_serde_impls branch from e8c9bc8 to e32d6e2 Compare February 20, 2025 02:27
@graphite-app graphite-app bot merged commit e32d6e2 into main Feb 20, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-20-refactor_allocator_linter_shorten_serde_impls branch February 20, 2025 02:33
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9254 will not alter performance

Comparing 02-20-refactor_allocator_linter_shorten_serde_impls (e32d6e2) with main (ef856f5)

Summary

✅ 33 untouched benchmarks

This was referenced Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant