refactor(oxc): apply clippy::needless_pass_by_ref_mut
#9253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Boshen
requested review from
overlookmotel,
Dunqing and
leaysgur
as code owners
github-actions
bot
added
A-parser
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merge activity
|
graphite-app
bot
force-pushed
the
02-20-refactor_oxc_apply_clippy_needless_pass_by_ref_mut_
branch
from
afb2c7c to
ef856f5
Compare
graphite-app
bot
deleted the
02-20-refactor_oxc_apply_clippy_needless_pass_by_ref_mut_
branch
CodSpeed Performance ReportMerging #9253 will not alter performanceComparing Summary
|
graphite-app bot
pushed a commit
that referenced
this pull request
Feb 21, 2025
#9253 enabled clippy's `needless_pass_by_ref_mut` rule, but kept it disabled for the `oxc_transformer` crate. This rule is really good as using `&` instead of `&mut` may allow the compiler to make more optimizations in some cases, as `&` guarantees that value is not changed during the function call which takes `&`. Enable this lint and fix all the warnings it highlights. The diff is large, but it's purely replacing `&mut` with `&` in lots of places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.