Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): apply cllippy::nursery rules #9232

Merged
merged 1 commit into from
Feb 20, 2025
Merged

refactor(rust): apply cllippy::nursery rules #9232

merged 1 commit into from
Feb 20, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Feb 19, 2025

No description provided.

@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 19, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier Area - Prettier A-cfg Area - Control Flow Graph A-ast-tools Area - AST tools A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 19, 2025
Boshen
Boshen commented Feb 19, 2025
View reviewed changes
@Boshen Boshen force-pushed the 02-19-chore_rust_enable_nursery_rules branch 2 times, most recently from e2240e1 to ffec2e8 Compare February 20, 2025 01:40
@Boshen Boshen changed the title chore(rust): enable nursery rules refactor(rust): apply cllippy::nursery rules Feb 20, 2025
@Boshen Boshen marked this pull request as ready for review February 20, 2025 01:45
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Feb 20, 2025
@Boshen Graphite App
Copy link
Member Author

Boshen commented Feb 20, 2025 •
edited by graphite-app bot
Loading

Merge activity

  • Feb 19, 8:46 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 19, 8:48 PM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 19, 8:51 PM EST: A user added this pull request to the Graphite merge queue.
  • Feb 19, 8:55 PM EST: A user merged this pull request with the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 02-19-chore_rust_enable_nursery_rules branch from 0eb8bbc to 9f36181 Compare February 20, 2025 01:51
@graphite-app graphite-app bot merged commit 9f36181 into main Feb 20, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 02-19-chore_rust_enable_nursery_rules branch February 20, 2025 01:55
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9232 will not alter performance

Comparing 02-19-chore_rust_enable_nursery_rules (9f36181) with main (63bb214)

Summary

✅ 33 untouched benchmarks

@oxc-bot oxc-bot mentioned this pull request Feb 21, 2025
Merged
@oxc-bot oxc-bot mentioned this pull request Feb 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur is a code owner

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-cfg Area - Control Flow Graph A-cli Area - CLI A-codegen Area - Code Generation A-editor Area - Editor and Language Server A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-prettier Area - Prettier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen