refactor(transformer/jsx): take ownership of Vec values by into_iter rather than drain
#9216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dunqing
changed the title
Vec values by into_iter rather than drain
github-actions
bot
added
A-transformer
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
changed the title
Vec values by into_iter rather than drainVec values by into_iter rather than drain
CodSpeed Performance ReportMerging #9216 will not alter performanceComparing Summary
|
|
I expect this to have some visible performance improvements but it is not, anyway I think this is a good refactor! |
overlookmotel
approved these changes
Feb 19, 2025
Merge activity
|
…er` rather than `drain` (#9216) This change I forgot to do this in #9209, In the case of owning `Vec`, we do not need to obtain the value owner through `drain` but `into_iter`. The diff in this PR is hard to diff. My purpose is to change `drain` to `into_iter`, other changes are for solving the borrow check and keeping the same output.
graphite-app
bot
force-pushed
the
02-19-refactor_transformer_take_ownership_of_vec_values_by_into_iter_rather_than_drain
branch
from
55a11bf to
25c4d69
Compare
graphite-app
bot
deleted the
02-19-refactor_transformer_take_ownership_of_vec_values_by_into_iter_rather_than_drain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change I forgot to do this in #9209, In the case of owning
Vec, we do not need to obtain the value owner throughdrainbutinto_iter.The diff in this PR is hard to diff. My purpose is to change
draintointo_iter, other changes are for solving the borrow check and keeping the same output.