Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(napi/transform): support enabling emitDecoratorMetadata #9190

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Feb 18, 2025

No description provided.

Copy link
Member Author

Dunqing commented Feb 18, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the title feat(napi/transform): support enabling emitDecoratorMetadata feat(napi/transform): support enabling emitDecoratorMetadata Feb 18, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label Feb 18, 2025
@Dunqing Dunqing force-pushed the 02-18-feat_napi_transform_support_enabling_emitdecoratormetadata branch from c910956 to e0d558a Compare February 18, 2025 03:29
Copy link
Contributor

@overlookmotel overlookmotel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've had a quick look through the PRs in this stack, but I'm not up to speed on how decorator metadata works, so I can't really review in full.

The only comment I have is the one I've made on #9189 (which I assume is nothing to worry about).

Do we maybe want to add 1 exec test (in a follow up) just to make sure it all works (including correctly interfacing with https://www.npmjs.com/package/reflect-metadata)?

But, that aside, if you're happy with it, please go ahead and merge.

@Dunqing Dunqing force-pushed the 02-18-feat_napi_transform_support_enabling_emitdecoratormetadata branch from e0d558a to fbf1f31 Compare February 19, 2025 07:15
@Dunqing Dunqing force-pushed the 02-18-feat_npm_runtime_add_decoratemetadata_helper_function branch from 086a176 to 2ad0f09 Compare February 19, 2025 07:15
@Dunqing
Copy link
Member Author

Dunqing commented Feb 19, 2025

Do we maybe want to add 1 exec test (in a follow up) just to make sure it all works (including correctly interfacing with https://www.npmjs.com/package/reflect-metadata)?

I've add an exec test in #9219

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 19, 2025
Copy link

graphite-app bot commented Feb 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-18-feat_npm_runtime_add_decoratemetadata_helper_function branch from 2ad0f09 to 6c24357 Compare February 19, 2025 14:05
@graphite-app graphite-app bot force-pushed the 02-18-feat_napi_transform_support_enabling_emitdecoratormetadata branch from fbf1f31 to 8a5051e Compare February 19, 2025 14:06
graphite-app bot pushed a commit that referenced this pull request Feb 19, 2025
Base automatically changed from 02-18-feat_npm_runtime_add_decoratemetadata_helper_function to main February 19, 2025 14:14
@graphite-app graphite-app bot merged commit 8a5051e into main Feb 19, 2025
16 checks passed
@graphite-app graphite-app bot deleted the 02-18-feat_napi_transform_support_enabling_emitdecoratormetadata branch February 19, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants