-
-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(npm/runtime): add decorateMetadata
helper function
#9189
feat(npm/runtime): add decorateMetadata
helper function
#9189
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
decorateMetadata
helper function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reflect.metadata
is not a native JS API. According to TS docs, it requires NPM package https://www.npmjs.com/package/reflect-metadata to "polyfill" this API.
Just checking that we don't need to do anything on our side to insert import 'reflect-metadata';
or something?
I assume the idea is that the user would handle this themselves, but I'm not up to speed on this whole decorator metadata thing, so I just wanted to check.
Yes, we don't need to do anything with |
086a176
to
2ad0f09
Compare
e58bd9b
to
a2aad51
Compare
Great. Thanks for explaining. |
Merge activity
|
a2aad51
to
90ba283
Compare
2ad0f09
to
6c24357
Compare
Copy from https://github.com/microsoft/TypeScript/blob/d85767abfd83880cea17cea70f9913e9c4496dcc/src/compiler/factory/emitHelpers.ts#L744-L753