fix(parser): fix SequenceExpression span
#9035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #9035 will not alter performanceComparing Summary
|
Boshen
force-pushed
the
02-11-fix_parser_fix_sequenceexpression_span
branch
from
eb51ba3 to
5ced24d
Compare
Merge activity
|
Boshen
force-pushed
the
02-11-fix_parser_fix_sequenceexpression_span
branch
from
29ef781 to
bba20f2
Compare
There's a very minor difference in span when `SequenceExpression` has empty spaces right after `(` or before `)`. For example, the following code has a different span/range depending on parsers: ```js ( 1, 2 ) ^^^^ (acorn, swc, babel) ^^^^^^ (oxc, tsc) ``` - oxc https://ast.sxzz.dev/#eNpNijEKgDAQBL9ybKUQBC19gC+wvCbECErMBaOiiH/3Cgu7md25EdBitofNbp3SBoOkg5xOySkVVBtqqFQV1ZsjESPLvjrfX8kzWvVFhj0om//dTcFHu3zJKFJtmcHxwfMCI14kXg== - acorn https://ast.sxzz.dev/#eNotijEOwjAMRa8SeQIpC4w9BQNiymIZD0WpHdlJJVT17hi12/vv/Q0qTPDBFZ1sbh0ytBBIahJMwZd0y+merjE15lYkpQJMC77YfFYpMIWo2Nl7gXx012HEz2/jIy/6HjX4zM3Y2VZ+oLH4/9JtcJEd9h+w8S5G Just for acorn estree conformance sake, I changed a span to match acorn, but I'm not sure if there's any real value in choosing one over another.
graphite-app
bot
force-pushed
the
02-11-fix_parser_fix_sequenceexpression_span
branch
from
bba20f2 to
567bc2c
Compare
graphite-app
bot
deleted the
02-11-fix_parser_fix_sequenceexpression_span
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a very minor difference in span when
SequenceExpressionhas empty spaces right after(or before).For example, the following code has a different span/range depending on parsers:
Just for acorn estree conformance sake, I changed a span to match acorn, but I'm not sure if there's any real value in choosing one over another.