chore(build): bump MSRV to 1.81.0 #8931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
C-cleanup
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
02-06-style_all_replace_allow_with_expect_
branch
from
bda2807 to
cb3f74c
Compare
overlookmotel
requested review from
Dunqing,
Boshen and
leaysgur
as code owners
overlookmotel
force-pushed
the
02-06-chore_build_bump_msrv_to_1.81.0
branch
from
b90ccb7 to
94c18f6
Compare
Dunqing
approved these changes
Feb 7, 2025
overlookmotel
force-pushed
the
02-06-chore_build_bump_msrv_to_1.81.0
branch
from
94c18f6 to
53b43ba
Compare
overlookmotel
force-pushed
the
02-06-style_all_replace_allow_with_expect_
branch
from
cb3f74c to
172916b
Compare
Merge activity
|
As noted in #8929, many Oxc crates won't compile at present with our MSRV of 1.80.0, due to the liberal use of `#[expect]` attribute, which wasn't stabilized until 1.81.0. It becomes a lint error in 1.81.0 to use `#[allow]`, so it'd seem to me pretty pointless to convert all the `#[expect]` attrs to `#[allow]` to honour our MSRV now, when we'll have to change them back to `#[expect]` again shortly. So I propose that we bump the MSRV to 1.81.0 early instead. Next minor version of Rust is out in 2 weeks anyway.
graphite-app
bot
force-pushed
the
02-06-style_all_replace_allow_with_expect_
branch
from
172916b to
a4a8e7d
Compare
graphite-app
bot
force-pushed
the
02-06-chore_build_bump_msrv_to_1.81.0
branch
from
53b43ba to
94b8d29
Compare
Base automatically changed from
02-06-style_all_replace_allow_with_expect_
to
main
February 7, 2025 14:58
Dunqing
pushed a commit
that referenced
this pull request
Feb 10, 2025
As noted in #8929, many Oxc crates won't compile at present with our MSRV of 1.80.0, due to the liberal use of `#[expect]` attribute, which wasn't stabilized until 1.81.0. It becomes a lint error in 1.81.0 to use `#[allow]`, so it'd seem to me pretty pointless to convert all the `#[expect]` attrs to `#[allow]` to honour our MSRV now, when we'll have to change them back to `#[expect]` again shortly. So I propose that we bump the MSRV to 1.81.0 early instead. Next minor version of Rust is out in 2 weeks anyway.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #8929, many Oxc crates won't compile at present with our MSRV of 1.80.0, due to the liberal use of
#[expect]attribute, which wasn't stabilized until 1.81.0.It becomes a lint error in 1.81.0 to use
#[allow], so it'd seem to me pretty pointless to convert all the#[expect]attrs to#[allow]to honour our MSRV now, when we'll have to change them back to#[expect]again shortly.So I propose that we bump the MSRV to 1.81.0 early instead. Next minor version of Rust is out in 2 weeks anyway.