Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(all): replace #[allow] with #[expect] #8930

Merged
merged 1 commit into from
Feb 7, 2025
Merged

style(all): replace #[allow] with #[expect] #8930

merged 1 commit into from
Feb 7, 2025

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 6, 2025 •
edited
Loading

Replace #[allow] with #[expect] through the whole codebase.

This also surfaced many places where the #[allow] attributes were outdated/pointless and could be removed entirely.

Only places #[allow] remains are:

  1. In generated code and macros, where lint errors may or may not be triggered depending on the generated code.
  2. A few places where clippy malfunctions. These use e.g. #[allow(unused, clippy::allow_attributes)].

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-semantic Area - Semantic A-cli Area - CLI A-minifier Area - Minifier A-ast Area - AST A-transformer Area - Transformer / Transpiler A-codegen Area - Code Generation A-prettier Area - Prettier A-cfg Area - Control Flow Graph A-isolated-declarations Isolated Declarations A-ast-tools Area - AST tools A-editor Area - Editor and Language Server C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 6, 2025
@overlookmotel Graphite App
Copy link
Contributor Author

overlookmotel commented Feb 6, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review February 6, 2025 18:51
@overlookmotel overlookmotel mentioned this pull request Feb 6, 2025
Merged
@overlookmotel overlookmotel marked this pull request as draft February 6, 2025 18:55
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8930 will not alter performance

Comparing 02-06-style_all_replace_allow_with_expect_ (a4a8e7d) with main (aeb122d)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 02-06-style_all_replace_allow_with_expect_ branch from bda2807 to cb3f74c Compare February 6, 2025 19:11
@overlookmotel overlookmotel marked this pull request as ready for review February 6, 2025 19:12
@overlookmotel overlookmotel mentioned this pull request Feb 6, 2025
Closed
@overlookmotel overlookmotel marked this pull request as draft February 6, 2025 19:49
@overlookmotel overlookmotel marked this pull request as ready for review February 6, 2025 19:49
@overlookmotel overlookmotel force-pushed the 02-06-style_all_replace_allow_with_expect_ branch from cb3f74c to 172916b Compare February 7, 2025 11:12
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 7, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 7, 2025 •
edited
Loading

Merge activity

@overlookmotel
style(all): replace #[allow] with #[expect] (#8930)
a4a8e7d 
Replace `#[allow]` with `#[expect]` through the whole codebase.

This also surfaced many places where the `#[allow]` attributes were outdated/pointless and could be removed entirely.

Only places `#[allow]` remains are:

1. In generated code and macros, where lint errors may or may not be triggered depending on the generated code.
2. A few places where clippy malfunctions. These use e.g. `#[allow(unused, clippy::allow_attributes)]`.
@graphite-app graphite-app bot force-pushed the 02-06-style_all_replace_allow_with_expect_ branch from 172916b to a4a8e7d Compare February 7, 2025 14:50
@graphite-app graphite-app bot merged commit a4a8e7d into main Feb 7, 2025
29 checks passed
@graphite-app graphite-app bot deleted the 02-06-style_all_replace_allow_with_expect_ branch February 7, 2025 14:58
Dunqing pushed a commit that referenced this pull request Feb 10, 2025
@overlookmotel @Dunqing
style(all): replace #[allow] with #[expect] (#8930)
c5bfb8a 
Replace `#[allow]` with `#[expect]` through the whole codebase.

This also surfaced many places where the `#[allow]` attributes were outdated/pointless and could be removed entirely.

Only places `#[allow]` remains are:

1. In generated code and macros, where lint errors may or may not be triggered depending on the generated code.
2. A few places where clippy malfunctions. These use e.g. `#[allow(unused, clippy::allow_attributes)]`.
This was referenced Feb 10, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

@Boshen Boshen Awaiting requested review from Boshen Boshen is a code owner

@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur is a code owner

Assignees
No one assigned
Labels
0-merge Merge with Graphite Merge Queue A-ast Area - AST A-ast-tools Area - AST tools A-cfg Area - Control Flow Graph A-cli Area - CLI A-codegen Area - Code Generation A-editor Area - Editor and Language Server A-isolated-declarations Isolated Declarations A-linter Area - Linter A-minifier Area - Minifier A-parser Area - Parser A-prettier Area - Prettier A-semantic Area - Semantic A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@overlookmotel