Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(data_structures)!: rename Stack::last_unchecked_mut method #8911

Conversation

overlookmotel
Copy link
Contributor

@overlookmotel overlookmotel commented Feb 5, 2025

Rename Stack::last_mut_unchecked to Stack::last_unchecked_mut. This matches std's naming convention e.g. get_unchecked_mut on slices.

Copy link
Contributor Author

overlookmotel commented Feb 5, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 5, 2025
@overlookmotel overlookmotel marked this pull request as ready for review February 5, 2025 14:03
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #8911 will not alter performance

Comparing 02-05-refactor_data_structures_rename_stack_last_unchecked_mut_method (bec8fee) with main (f6b6e70)

Summary

✅ 33 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as draft February 5, 2025 14:19
@overlookmotel overlookmotel marked this pull request as ready for review February 5, 2025 14:20
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Feb 5, 2025
Copy link
Member

Dunqing commented Feb 5, 2025

Merge activity

  • Feb 5, 11:16 AM EST: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 5, 11:16 AM EST: A user added this pull request to the Graphite merge queue.
  • Feb 5, 11:25 AM EST: A user merged this pull request with the Graphite merge queue.

…#8911)

Rename `Stack::last_mut_unchecked` to `Stack::last_unchecked_mut`. This matches `std`'s naming convention e.g. `get_unchecked_mut` on slices.
@graphite-app graphite-app bot force-pushed the 02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types branch from 39b0c9c to 0a74cf5 Compare February 5, 2025 16:17
@graphite-app graphite-app bot force-pushed the 02-05-refactor_data_structures_rename_stack_last_unchecked_mut_method branch from bd08016 to bec8fee Compare February 5, 2025 16:18
Base automatically changed from 02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types to main February 5, 2025 16:22
@graphite-app graphite-app bot merged commit bec8fee into main Feb 5, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 02-05-refactor_data_structures_rename_stack_last_unchecked_mut_method branch February 5, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-merge Merge with Graphite Merge Queue C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants