feat(data_structures): add first and first_mut methods to stack types
#8908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-transformer
CodSpeed Performance ReportMerging #8908 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types
branch
from
ee91832 to
3b650c0
Compare
overlookmotel
changed the base branch from
02-05-docs_data_structures_correct_doc_comments_for_sparsestack_
to
graphite-base/8908
overlookmotel
force-pushed
the
graphite-base/8908
branch
from
a8845fd to
f6b6e70
Compare
overlookmotel
force-pushed
the
02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types
branch
from
3b650c0 to
3168f14
Compare
overlookmotel
force-pushed
the
02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types
branch
2 times, most recently
from
3c19274 to
39b0c9c
Compare
Dunqing
approved these changes
Feb 5, 2025
Merge activity
|
…ypes (#8908) Add `first` and `first_mut` methods to `NonEmptyStack` and `SparseStack`. * For `NonEmptyStack`, these methods for can be infallible, as the stack is guaranteed not to be empty. * For `SparseStack`, these methods can use the more efficient methods on `NonEmptyStack`. Originally suggested by @branchseer in #8691.
graphite-app
bot
force-pushed
the
02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types
branch
from
39b0c9c to
0a74cf5
Compare
graphite-app
bot
deleted the
02-05-feat_data_structures_add_first_and_first_mut_methods_to_stack_types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
firstandfirst_mutmethods toNonEmptyStackandSparseStack.NonEmptyStack, these methods for can be infallible, as the stack is guaranteed not to be empty.SparseStack, these methods can use the more efficient methods onNonEmptyStack.Originally suggested by @branchseer in #8691.