Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(traverse): add TraverseCtx::change_parent_scope_for_expression #8510

Conversation

Dunqing
Copy link
Member

@Dunqing Dunqing commented Jan 15, 2025

It is used for moving an expression to another block, then we need to change the parent for it.

@github-actions github-actions bot added the C-enhancement Category - New feature or request label Jan 15, 2025
Copy link
Member Author

Dunqing commented Jan 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codspeed-hq bot commented Jan 15, 2025

CodSpeed Performance Report

Merging #8510 will not alter performance

Comparing 01-15-feat_traverse_add_traversectx_change_parent_scope_for_expression (f60110a) with main (a368726)

Summary

✅ 32 untouched benchmarks

@overlookmotel
Copy link
Contributor

Probably I'm missing something, but how is this different from TraverseScoping::insert_scope_below_expression?

@Dunqing
Copy link
Member Author

Dunqing commented Jan 16, 2025

Probably I'm missing something, but how is this different from TraverseScoping::insert_scope_below_expression?

Oh, it is no different, and it is better than change_parent_scope_for_expression!

@Dunqing Dunqing closed this Jan 16, 2025
@overlookmotel overlookmotel deleted the 01-15-feat_traverse_add_traversectx_change_parent_scope_for_expression branch January 16, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category - New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants