Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(mangler): allocate data in arena #8471

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 14, 2025

No description provided.

Copy link

graphite-app bot commented Jan 14, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@Boshen Boshen changed the title 01 14 perf mangler allocate data in arena perf(mangler): allocate data in arena Jan 14, 2025
@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label Jan 14, 2025
@Boshen Boshen force-pushed the 01-14-perf_mangler_allocate_data_in_arena branch from 65b053d to e56b1ba Compare January 14, 2025 02:14
Copy link

codspeed-hq bot commented Jan 14, 2025

CodSpeed Performance Report

Merging #8471 will improve performances by 16.74%

Comparing 01-14-perf_mangler_allocate_data_in_arena (e56b1ba) with main (dba054f)

Summary

⚡ 3 improvements
✅ 29 untouched benchmarks

Benchmarks breakdown

Benchmark main 01-14-perf_mangler_allocate_data_in_arena Change
mangler[antd.js] 7 ms 6.7 ms +4.28%
mangler[react.development.js] 196.1 µs 168 µs +16.74%
mangler[typescript.js] 11.6 ms 10.8 ms +7.25%

@Boshen Boshen merged commit 31dac22 into main Jan 14, 2025
27 checks passed
@Boshen Boshen deleted the 01-14-perf_mangler_allocate_data_in_arena branch January 14, 2025 02:24
Boshen added a commit that referenced this pull request Jan 14, 2025
## [0.46.0] - 2025-01-14

- 7eb6ccd ast: [**BREAKING**] Remove unused and not useful `ContentHash`
(#8483) (Boshen)

### Features

- 8accfef minifier: Minify `var x; void x` -> `void 0` (#8466) (Boshen)
- 870a583 minifier: Fold `false['toString']` (#8447) (Boshen)
- 4ad695d napi/minify: Implement napi (#8478) (Boshen)
- 9d550aa span: Add `Atom::r#static` (#8479) (_Kerman)

### Bug Fixes

- 4071878 isolated-declarations: Retain `declare` declarations when they
are exported (#8477) (Dunqing)
- 7ee7634 isolated-declarations: Import statement disappears when import
binding is referenced in nested `typeof` (#8476) (Dunqing)
- 7252cb0 isolated-declarations: Unexpected error when global `Symbol`
as property key (#8475) (Dunqing)
- 4c6675c minifier: Do not convert while to fors in DCE (#8484) (Boshen)
- 1d6e84d minifier: Fix incorrect `null.toString()` and `1n.toString()`
(#8464) (Boshen)
- 25d4bf9 minifier: Remove usage of empty spans (#8462) (Boshen)
- dd64340 minifier: Keep `return undefined` in async generator function
(#8439) (Boshen)
- c444de8 transformer/arrow-functions: Transform `this` and `super`
incorrectly in async arrow function (#8435) (Dunqing)
- 270245f transformer/typescript: Correct the semantic for
TSImportEqualsDeclaration transformation (#8463) (Dunqing)
- 2a400d6 transformer/typescript: Retain TSImportEqualsDeclaration when
it is exported (Dunqing)
- ab694b0 transformer/typescript: Retain `TSImportEqualsDeclaration` in
`namespace` when its binding has been referenced or
`onlyRemoveTypeImports` is true (#8458) (Dunqing)

### Performance

- 7a8200c mangler: Allocate base54 name without heap allocation (#8472)
(Boshen)
- 31dac22 mangler: Allocate data in arena (#8471) (Boshen)
- 8fc238a minifier: Merge `Normalize` and `RemoveSyntax` pass (#8467)
(Boshen)
- 372eb09 minifier: Preallocate mangler's semantic data (#8451) (Boshen)

### Refactor

- 6e64eef codegen: Remove `match_expression!` (#8450) (Boshen)
- de5b288 span: Rename `Atom::new_const` method (#8480) (overlookmotel)
- c83ce5c transformer/typescript: Improve transforming namespace (#8459)
(Dunqing)

Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-performance Category - Solution not expected to change functional behavior, only performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant