Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(rust): incompatible-rust-versions = "fallback" + cargo update #8407

Merged
merged 1 commit into from
Jan 10, 2025
Merged

build(rust): incompatible-rust-versions = "fallback" + cargo update #8407

merged 1 commit into from
Jan 10, 2025

Conversation

Boshen
Copy link
Member

@Boshen Boshen commented Jan 10, 2025

No description provided.

@Boshen Graphite App
Copy link
Member Author

Boshen commented Jan 10, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Boshen Boshen mentioned this pull request Jan 10, 2025
Merged
@Boshen Boshen force-pushed the 01-10-build_rust_resolver_3_and_cargo_update_ branch from 4743225 to cbf76fe Compare January 10, 2025 05:51
@Boshen Boshen requested a review from overlookmotel as a code owner January 10, 2025 05:51
@Boshen Boshen force-pushed the 01-10-build_rust_resolver_3_and_cargo_update_ branch 3 times, most recently from d8c80f7 to 6ecd1c7 Compare January 10, 2025 06:32
@Boshen Boshen changed the title build(rust): resolver = "3" + rust-version = "1.80" + cargo update build(rust): incompatible-rust-versions = "fallback" + rust-version = "1.80" + cargo update Jan 10, 2025
@Boshen Boshen changed the title build(rust): incompatible-rust-versions = "fallback" + rust-version = "1.80" + cargo update build(rust): incompatible-rust-versions = "fallback" + cargo update Jan 10, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 10, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #8407 will not alter performance

Comparing 01-10-build_rust_resolver_3_and_cargo_update_ (a006955) with main (0726581)

Summary

✅ 29 untouched benchmarks

@graphite-app Graphite App
Copy link

graphite-app bot commented Jan 10, 2025 •
edited
Loading

Merge activity

@Boshen Boshen force-pushed the 01-10-build_rust_resolver_3_and_cargo_update_ branch from 6ecd1c7 to a006955 Compare January 10, 2025 06:42
@graphite-app graphite-app bot merged commit a006955 into main Jan 10, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 01-10-build_rust_resolver_3_and_cargo_update_ branch January 10, 2025 06:47
@overlookmotel overlookmotel mentioned this pull request Jan 10, 2025
Merged
Boshen pushed a commit that referenced this pull request Jan 11, 2025
@overlookmotel
refactor(data_structures): remove NonNull shim (#8423)
9c1844a 
The `NonNull` shim in `oxc_data_structures` was just to emulate native APIs which only became stable in Rust 1.80.0. #8407 bumped our MSRV to 1.80.0, so now we can remove the shim and use `std::ptr::NonNull` directly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overlookmotel overlookmotel Awaiting requested review from overlookmotel overlookmotel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Boshen