wasm: panicked at crates/oxc_span/src/span.rs:394:21

[Dunqing]

panicked at crates/oxc_span/src/span.rs:394:21:
byte index 20 is not a char boundary; it is inside '😢' (bytes 17..21) of const A /* Hello 😢 */ = 0;

Reproduction

Code like:

const A /* Hello 😢 */ = 0;

1. Open the Playground
2. Error shown in the console

[Boshen]

I made a mistake here, I called convert ast pritor to converting comments

oxc/crates/oxc_wasm/src/lib.rs

Lines 473 to 492 in 3031845

	fn convert_ast(&mut self, program: &mut Program) {
	Utf8ToUtf16::new().convert(program);
	self.ast_json = program.to_pretty_estree_ts_json();
	self.comments = Self::map_comments(program.source_text, &program.comments);
	}
	fn map_comments(source_text: &str, comments: &[OxcComment]) -> Vec<Comment> {
	comments
	.iter()
	.map(|comment| Comment {
	r#type: match comment.kind {
	CommentKind::Line => CommentType::Line,
	CommentKind::Block => CommentType::Block,
	},
	value: comment.content_span().source_text(source_text).to_string(),
	start: comment.span.start,
	end: comment.span.end,
	})
	.collect()
	}

[Boshen]

I think we should move comment serialization into to_estree_json, and remove the separated out comments field from napi and wasm output.

Acorn doesn't have a comments array output, but we can conform it to typescript eslint estree

"comments": [
    {
      "type": "Block",
      "value": " asdf ",
      "range": [
        0,
        10
      ],
      "loc": {
        "start": {
          "line": 1,
          "column": 0
        },
        "end": {
          "line": 1,
          "column": 10
        }
      }
    }
  ]

[Boshen]

Fixed in #9349