fix(parser): fix false positive parsing optional member expr

oxc-project · Mar 4, 2025 · b38b20b · b38b20b
1 parent 2326cef
commit b38b20b
Show file tree

Hide file tree

Showing 5 changed files with 36 additions and 5 deletions.
diff --git a/crates/oxc_parser/src/js/expression.rs b/crates/oxc_parser/src/js/expression.rs
@@ -711,10 +711,16 @@ impl<'a> ParserImpl<'a> {
                         kind if kind.is_identifier_name() => {
                             self.parse_static_member_expression(lhs_span, lhs, true)?
                         }
-                        Kind::Eof => {
-                            return Err(diagnostics::unexpected_end(self.cur_token().span()));
+                        Kind::Bang
+                        | Kind::LAngle
+                        | Kind::LParen
+                        | Kind::NoSubstitutionTemplate
+                        | Kind::ShiftLeft
+                        | Kind::TemplateHead
+                        | Kind::LBrack => break,
+                        _ => {
+                            return Err(diagnostics::unexpected_token(self.cur_token().span()));
                         }
-                        _ => break,
                     }
                 }
                 // computed member expression is not allowed in decorator

diff --git a/tasks/coverage/misc/fail/oxc-9525-1.js b/tasks/coverage/misc/fail/oxc-9525-1.js
@@ -0,0 +1 @@
+x?.;
diff --git a/tasks/coverage/misc/fail/oxc-9525-2.js b/tasks/coverage/misc/fail/oxc-9525-2.js
@@ -0,0 +1 @@
+[x?.];
diff --git a/tasks/coverage/misc/fail/oxc-9525-3.js b/tasks/coverage/misc/fail/oxc-9525-3.js
@@ -0,0 +1,3 @@
+() => {
+  x?.
+}
diff --git a/tasks/coverage/snapshots/parser_misc.snap b/tasks/coverage/snapshots/parser_misc.snap
@@ -1,7 +1,7 @@
 parser_misc Summary:
 AST Parsed     : 32/32 (100.00%)
 Positive Passed: 32/32 (100.00%)
-Negative Passed: 27/27 (100.00%)
+Negative Passed: 30/30 (100.00%)
 
   × Unexpected token
    ╭─[misc/fail/oxc-169.js:2:1]
@@ -272,13 +272,33 @@ Negative Passed: 27/27 (100.00%)
  5 │   }
    ╰────
 
-  × Unexpected end of file
+  × Unexpected token
    ╭─[misc/fail/oxc-9497.js:2:8]
  1 │ let repro = {};
  2 │ repro.f?.
    ·        ──
    ╰────
 
+  × Unexpected token
+   ╭─[misc/fail/oxc-9525-1.js:1:2]
+ 1 │ x?.;
+   ·  ──
+   ╰────
+
+  × Unexpected token
+   ╭─[misc/fail/oxc-9525-2.js:1:3]
+ 1 │ [x?.];
+   ·   ──
+   ╰────
+
+  × Unexpected token
+   ╭─[misc/fail/oxc-9525-3.js:2:4]
+ 1 │ () => {
+ 2 │   x?.
+   ·    ──
+ 3 │ }
+   ╰────
+
   × The keyword 'let' is reserved
    ╭─[misc/fail/oxc.js:3:1]
  2 │
-Original file line number
+Diff line change
@@ -0,0 +1,3 @@
+    () => {
+      x?.
+    }