diff --git a/Cargo.toml b/Cargo.toml index 1efeaf391b1d7..a5fcc7a3197c2 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -75,6 +75,7 @@ significant_drop_in_scrutinee = "warn" iter_on_single_items = "warn" unused_peekable = "warn" too_long_first_doc_paragraph = "warn" +suspicious_operation_groupings = "warn" # cargo cargo = { level = "warn", priority = -1 } multiple_crate_versions = "allow" diff --git a/crates/oxc_minifier/src/peephole/minimize_conditional_expression.rs b/crates/oxc_minifier/src/peephole/minimize_conditional_expression.rs index 1ada67a43bb3f..5c745c99c47a7 100644 --- a/crates/oxc_minifier/src/peephole/minimize_conditional_expression.rs +++ b/crates/oxc_minifier/src/peephole/minimize_conditional_expression.rs @@ -247,8 +247,8 @@ impl<'a> PeepholeOptimizations { // we can improve compression by allowing side effects on one side if the other side is // an identifier that is not modified after it is declared. // but for now, we only perform compression if neither side has side effects. - && !(expr.test.may_have_side_effects(&ctx) - || consequent.callee.may_have_side_effects(&ctx)) + && !expr.test.may_have_side_effects(&ctx) + && !consequent.callee.may_have_side_effects(&ctx) && ctx.expr_eq(&consequent.callee, &alternate.callee) && consequent .arguments