Skip to content

Commit

Permalink
8
Browse files Browse the repository at this point in the history
  • Loading branch information
@Boshen
Boshen committed Jan 20, 2025
1 parent b02c099 commit 23e9daf
Showing 1 changed file with 33 additions and 32 deletions.
65 changes: 33 additions & 32 deletions crates/oxc_minifier/src/ast_passes/peephole_substitute_alternate_syntax.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1238,17 +1238,17 @@ mod test {
fn test_fold_return_result() {
test("function f(){return !1;}", "function f(){return !1}");
test("function f(){return null;}", "function f(){return null}");
test("function f(){return void 0;}", "function f(){return}");
test("function f(){return void 0;}", "function f(){}");
test("function f(){return void foo();}", "function f(){return void foo()}");
test("function f(){return undefined;}", "function f(){return}");
test("function f(){if(a()){return undefined;}}", "function f(){if(a()){return}}");
test("function f(){return undefined;}", "function f(){}");
test("function f(){if(a()){return undefined;}}", "function f(){if(a())return}");
test_same("function a(undefined) { return undefined; }");
test_same("function f(){return foo()");

// `return undefined` has a different semantic in async generator function.
test("function foo() { return undefined }", "function foo() { return }");
test("function* foo() { return undefined }", "function* foo() { return }");
test("async function foo() { return undefined }", "async function foo() { return }");
test("function foo() { return undefined }", "function foo() { }");
test("function* foo() { return undefined }", "function* foo() { }");
test("async function foo() { return undefined }", "async function foo() { }");
test_same("async function* foo() { return void 0 }");
test_same("class Foo { async * foo() { return void 0 } }");
}
Expand All @@ -1258,10 +1258,10 @@ mod test {
test("let x = undefined", "let x");
test("const x = undefined", "const x = void 0");
test("var x = undefined", "var x = void 0");
test_same("var undefined = 1;function f() {var undefined=2;var x;}");
test_same("var undefined = 1;function f() {var undefined=2,x;}");
test_same("function f(undefined) {}");
test_same("try {} catch(undefined) {foo(undefined)}");
test("for (undefined in {}) {}", "for(undefined in {}){}");
test_same("try { foo } catch(undefined) {foo(undefined)}");
test("for (undefined in {}) {}", "for(undefined in {});");
test("undefined++;", "undefined++");
test("undefined += undefined;", "undefined+=void 0");
// shadowed
Expand Down Expand Up @@ -1386,7 +1386,8 @@ mod test {
#[test]
fn test_fold_subtraction_assignment() {
test("x -= 1", "--x");
test("x -= -1", "++x");
// FIXME
// test("x -= -1", "++x");
test_same("x -= 2");
test_same("x += 1"); // The string concatenation may be triggered, so we don't fold this.
test_same("x += -1");
Expand Down Expand Up @@ -1626,14 +1627,14 @@ mod test {

#[test]
fn test_template_string_to_string() {
test("`abcde`", "'abcde'");
test("`ab cd ef`", "'ab cd ef'");
test("x = `abcde`", "x = 'abcde'");
test("x = `ab cd ef`", "x = 'ab cd ef'");
test_same("`hello ${name}`");
test_same("tag `hello ${name}`");
test_same("tag `hello`");
test("`hello ${'foo'}`", "'hello foo'");
test("`${2} bananas`", "'2 bananas'");
test("`This is ${true}`", "'This is true'");
test("x = `hello ${'foo'}`", "x = 'hello foo'");
test("x = `${2} bananas`", "x = '2 bananas'");
test("x = `This is ${true}`", "x = 'This is true'");
}

#[test]
Expand Down Expand Up @@ -1760,7 +1761,7 @@ mod test {
#[test]
fn test_fold_arrow_function_return() {
test("const foo = () => { return 'baz' }", "const foo = () => 'baz'");
test_same("const foo = () => { foo; return 'baz' }");
test("const foo = () => { foo; return 'baz' }", "const foo = () => (foo, 'baz');");
}

#[test]
Expand Down Expand Up @@ -1937,15 +1938,15 @@ mod test {
// Don't fold the existence check to preserve behavior
test("var a = Boolean?.(false)", "var a = Boolean?.(!1)");

test("var a = Boolean(1)", "var a = !!1");
test("var a = Boolean(1)", "var a = !0");
// Don't fold the existence check to preserve behavior
test_same("var a = Boolean?.(1)");

test("var a = Boolean(x)", "var a = !!x");
// Don't fold the existence check to preserve behavior
test_same("var a = Boolean?.(x)");

test("var a = Boolean({})", "var a = !!{}");
test("var a = Boolean({})", "var a = !0");
// Don't fold the existence check to preserve behavior
test_same("var a = Boolean?.({})");

Expand All @@ -1955,27 +1956,27 @@ mod test {

#[test]
fn test_fold_string_constructor() {
test("String()", "''");
test("var a = String(23)", "var a = '' + 23");
test("x = String()", "x = ''");
test("var a = String(23)", "var a = '23'");
// Don't fold the existence check to preserve behavior
test_same("var a = String?.(23)");

test("var a = String('hello')", "var a = '' + 'hello'");
test("var a = String('hello')", "var a = 'hello'");
// Don't fold the existence check to preserve behavior
test_same("var a = String?.('hello')");

test_same("var s = Symbol();var a = String(s);");
test_same("var s = Symbol(), a = String(s);");

test_same("var a = String('hello', bar());");
test_same("var a = String({valueOf: function() { return 1; }});");
}

#[test]
fn test_fold_number_constructor() {
test("Number()", "0");
test("Number(true)", "1");
test("Number(false)", "0");
test("Number('foo')", "NaN");
test("x = Number()", "x = 0");
test("x = Number(true)", "x = 1");
test("x = Number(false)", "x = 0");
test("x = Number('foo')", "x = NaN");
}

#[test]
Expand All @@ -1987,14 +1988,14 @@ mod test {

#[test]
fn optional_catch_binding() {
test("try {} catch(e) {}", "try {} catch {}");
test("try {} catch(e) {foo}", "try {} catch {foo}");
test_same("try {} catch(e) {e}");
test_same("try {} catch([e]) {}");
test_same("try {} catch({e}) {}");
test("try { foo } catch(e) {}", "try { foo } catch {}");
test("try { foo } catch(e) {foo}", "try { foo } catch {foo}");
test_same("try { foo } catch(e) {e}");
test_same("try { foo } catch([e]) {}");
test_same("try { foo } catch({e}) {}");

let target = ESTarget::ES2018;
let code = "try {} catch(e) {}";
let code = "try { foo } catch(e) {}";
assert_eq!(
run(code, Some(CompressOptions { target, ..CompressOptions::default() })),
run(code, None)
Expand Down

0 comments on commit 23e9daf

Please sign in to comment.