Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Fix failing E2E tests #12277

Merged
merged 15 commits into from
Mar 13, 2025
Merged

[full-ci] Fix failing E2E tests #12277

merged 15 commits into from
Mar 13, 2025

Conversation

deyankiteworks
Copy link
Member

@deyankiteworks deyankiteworks commented Mar 10, 2025

Description

This PR fixes some E2E tests which are failing after renaming the role "Can edit" to "Can edit without versions".

Related Issue

Motivation and Context

Some of the E2E tests for PR #11116 were failing after the changes.
To be able to fix them, first these changes should be merged into stable-11.0 branch of the web repo.

How Has This Been Tested?

  • Tested locally
  • Tested by executing the Drone job

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Copy link

update-docs bot commented Mar 10, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2025

CLA assistant check
All committers have signed the CLA.

@2403905 2403905 changed the title Fix failing E2E tests [full-ci]Fix failing E2E tests Mar 10, 2025
@LukasHirt
Copy link
Collaborator

When this is merged, we will need to get it also into master branch.

@deyankiteworks deyankiteworks self-assigned this Mar 13, 2025
@deyankiteworks deyankiteworks changed the title [full-ci]Fix failing E2E tests [full-ci] Fix failing E2E tests Mar 13, 2025
@deyankiteworks deyankiteworks requested a review from mmattel March 13, 2025 12:43
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deyankiteworks deyankiteworks merged commit efca668 into stable-11.0 Mar 13, 2025
4 checks passed
@deyankiteworks deyankiteworks deleted the TranslationFix branch March 13, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants