This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
OcSelect: add support for showing default values #1634
Open
dschmidt
wants to merge
3
commits into
master
Choose a base branch
from
work/select_defaultValue
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+220
−28
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
Enhancement: Add support for showing default values in OcSelect | ||
|
||
We've added a `defaultValue` prop to OcSelect. | ||
|
||
The value provided as `defaultValue` is selected when the actual `value` is `null`. | ||
When the default value is shown the clear button is hidden because you can't clear the default. | ||
|
||
https://github.com/owncloud/owncloud-design-system/pull/1634 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -3,12 +3,16 @@ | |||||
<label :for="id" v-text="label" /> | ||||||
<vue-select | ||||||
ref="select" | ||||||
:clearable="showClearButton" | ||||||
:disabled="disabled" | ||||||
:filter="filter" | ||||||
:input-id="id" | ||||||
class="oc-select" | ||||||
:value="displayValue" | ||||||
@input="onInput" | ||||||
@option:selecting="onOptionSelecting" | ||||||
v-bind="additionalAttributes" | ||||||
v-on="$listeners" | ||||||
v-on="listeners" | ||||||
> | ||||||
<template #search="{ attributes, events }"> | ||||||
<input class="vs__search" v-bind="attributes" @input="userInput" v-on="events" /> | ||||||
|
@@ -51,6 +55,31 @@ export default { | |||||
required: false, | ||||||
default: () => uniqueId("oc-select-"), | ||||||
}, | ||||||
/** | ||||||
* Whether or not the select component should have a dedicated button for clearing the selection. | ||||||
*/ | ||||||
clearButtonEnabled: { | ||||||
type: Boolean, | ||||||
required: false, | ||||||
default: true, | ||||||
}, | ||||||
/** | ||||||
* Value to preselect when no value is provided | ||||||
* This does not set `value` automatically. | ||||||
* The user needs to explicitly select the value to set it. | ||||||
*/ | ||||||
defaultValue: { | ||||||
required: false, | ||||||
default: null, | ||||||
}, | ||||||
/** | ||||||
* Disable the select component | ||||||
*/ | ||||||
disabled: { | ||||||
type: Boolean, | ||||||
required: false, | ||||||
default: false, | ||||||
}, | ||||||
/** | ||||||
* Function to filter items when searching | ||||||
*/ | ||||||
|
@@ -75,14 +104,6 @@ export default { | |||||
return search.length ? fuse.search(search).map(({ item }) => item) : fuse.list | ||||||
}, | ||||||
}, | ||||||
/** | ||||||
* Disable the select component | ||||||
*/ | ||||||
disabled: { | ||||||
type: Boolean, | ||||||
required: false, | ||||||
default: false, | ||||||
}, | ||||||
/** | ||||||
* Label of the select component | ||||||
* ATTENTION: this shadows the vue-select prop `label`. If you need access to that use `optionLabel`. | ||||||
|
@@ -99,6 +120,12 @@ export default { | |||||
type: String, | ||||||
default: null, | ||||||
}, | ||||||
/** | ||||||
* Current value of the select component. | ||||||
*/ | ||||||
value: { | ||||||
default: null, | ||||||
}, | ||||||
}, | ||||||
|
||||||
computed: { | ||||||
|
@@ -107,7 +134,24 @@ export default { | |||||
if (this.optionLabel) { | ||||||
additionalAttrs["label"] = this.optionLabel | ||||||
} | ||||||
return { ...this.$attrs, ...additionalAttrs } | ||||||
const attrs = { ...this.$attrs, ...additionalAttrs } | ||||||
delete attrs.clearable | ||||||
return attrs | ||||||
}, | ||||||
displayValue() { | ||||||
return this.value || this.defaultValue | ||||||
}, | ||||||
listeners() { | ||||||
const listeners = this.$listeners | ||||||
|
||||||
// Delete listeners for events which are emitted via methods | ||||||
delete listeners["input"] | ||||||
delete listeners["change"] | ||||||
|
||||||
return listeners | ||||||
}, | ||||||
showClearButton() { | ||||||
return this.clearButtonEnabled && this.value !== null | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
}, | ||||||
}, | ||||||
|
||||||
|
@@ -128,6 +172,23 @@ export default { | |||||
*/ | ||||||
this.$emit("search:input", event.target.value) | ||||||
}, | ||||||
onInput(value) { | ||||||
// selecting a value is handled via onOptionSelecting, we just nead to handle clear events here | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. *need |
||||||
if (value !== null) { | ||||||
return | ||||||
} | ||||||
|
||||||
this.onOptionSelecting(null) | ||||||
}, | ||||||
/** | ||||||
* We use the option:selecting event as it's the only one that fires when an option is reselected | ||||||
* When we are showing a `defaultValue` we need to allow the user to explicitly set that value | ||||||
* to override the default because a default might change one day | ||||||
*/ | ||||||
onOptionSelecting(value) { | ||||||
this.$emit("input", value) | ||||||
this.$emit("change", value) | ||||||
}, | ||||||
}, | ||||||
} | ||||||
</script> | ||||||
|
@@ -240,6 +301,28 @@ prevent clearing the selected value by hitting `delete`. | |||||
</script> | ||||||
``` | ||||||
|
||||||
### Providing a default value | ||||||
We can provide a `defaultValue` to `oc-select` that is preselected when `value` is `null`. | ||||||
When the `defaultValue` is displayed the clear button is automatically disabled. | ||||||
|
||||||
```js | ||||||
<template> | ||||||
<div class="oc-docs-width-medium"> | ||||||
<oc-select v-model="selected" :options="['Apple', 'Bannana', 'Orange', 'Pear']" default-value="Orange" /> | ||||||
<p> | ||||||
Selected: {{ selected === null ? "null" : selected }} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
</p> | ||||||
</div> | ||||||
</template> | ||||||
<script> | ||||||
export default { | ||||||
data: () => ({ | ||||||
selected: null | ||||||
}) | ||||||
}; | ||||||
</script> | ||||||
``` | ||||||
|
||||||
### Multiple selection | ||||||
```js | ||||||
<template> | ||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked how the update journey in
web
would look like and we seem to give all labels this class, which doesn't style anything initially but sometimes is used to target the label for stylingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense but possibly belongs into the original pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but that one is merged already (and I somehow ended here without understanding this is not the original ;D my bad, could you include it either way?