Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Role Translations #11098

Closed
wants to merge 3 commits into from
Closed

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Mar 5, 2025

Fixes the translation of the editor roles. Old roles are now named "can edit without versions" to be in sync with space logic

Relates to #11104 (needs masterport for closing)

Signed-off-by: Julian Koberg <jkoberg@MBP-Julian-Koberg.local>
@kobergj kobergj mentioned this pull request Mar 6, 2025
22 tasks
@saw-jan
Copy link
Member

saw-jan commented Mar 10, 2025

e2e tests need to be adjusted. But that can be done only after merging this PR.

@phil-davis
Copy link
Contributor

e2e tests need to be adjusted. But that can be done only after merging this PR.

And "Alice" shares the following resources using the sidebar panel # file:/drone/src/webTestRunner/tests/e2e/cucumber/steps/ui/shares.ts:23
       | resource     | recipient | type  | role     |
       | sharedFolder | Brian     | user  | Can edit |
       | sharedFolder | Carol     | user  | Can edit |
       | sharedFolder | David     | user  | Can edit |
       | sharedFolder | Edith     | user  | Can edit |
       | sharedFolder | sales     | group | Can edit |
       | sharedFolder | finance   | group | Can edit |
       | sharedFolder | security  | group | Can edit |
       page.click: Timeout 30000ms exceeded.
       Call log:
         - waiting for locator('//span[contains(@class,"roles-select-role-item")]/span[text()="Can edit"]')

IMO we need to adjust test scenarios like this, in this PR. And get the test scenarios to pass in this PR. Is that correct?

Signed-off-by: Julian Koberg <jkoberg@MBP-Julian-Koberg.local>
@saw-jan
Copy link
Member

saw-jan commented Mar 10, 2025

IMO we need to adjust test scenarios like this, in this PR. And get the test scenarios to pass in this PR. Is that correct?

@phil-davis we cannot change the webUI test code in ocis. What we usually do/did, merge ocis PR with web-e2e skipped and fixed the web-e2e tests with the ocis commit-id bump in the web

@phil-davis
Copy link
Contributor

we cannot change the webUI test code in ocis

I forgot that the e2e webUI tests are pulled in from a different repo!

@deyankiteworks
Copy link
Member

deyankiteworks commented Mar 13, 2025

@saw-jan @phil-davis We already have a fix for this issue - check PR #11116.
We already fixed the failing E2E tests in WebUI repo - PR #12277.
Thanks to @2403905 and @nirajacharya2 for the help.

@deyankiteworks
Copy link
Member

All of the fixes have been merged already in branch stable-7.1. Check PR #11116.

@deyankiteworks
Copy link
Member

Closing this PR as it duplicates PR #11116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants