-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Role Translations #11098
Fix Role Translations #11098
Conversation
Signed-off-by: Julian Koberg <jkoberg@MBP-Julian-Koberg.local>
e2e tests need to be adjusted. But that can be done only after merging this PR. |
IMO we need to adjust test scenarios like this, in this PR. And get the test scenarios to pass in this PR. Is that correct? |
Signed-off-by: Julian Koberg <jkoberg@MBP-Julian-Koberg.local>
@phil-davis we cannot change the webUI test code in ocis. What we usually do/did, merge ocis PR with web-e2e skipped and fixed the web-e2e tests with the ocis commit-id bump in the web |
I forgot that the e2e webUI tests are pulled in from a different repo! |
|
@saw-jan @phil-davis We already have a fix for this issue - check PR #11116. |
All of the fixes have been merged already in branch |
Closing this PR as it duplicates PR #11116. |
Fixes the translation of the editor roles. Old roles are now named "can edit without versions" to be in sync with space logic
Relates to #11104 (needs masterport for closing)