Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing permissions for federated shares #11022

Closed
kobergj opened this issue Feb 3, 2025 · 4 comments · Fixed by #11041
Closed

Changing permissions for federated shares #11022

kobergj opened this issue Feb 3, 2025 · 4 comments · Fixed by #11041
Assignees
@2403905

Comments

@kobergj
Copy link
Collaborator

kobergj commented Feb 3, 2025 •
edited
Loading

PATCHing federated shares is not supported by the server. We should block editing federated shares in the webfrontend. See comment - proposal got rejected
@kobergj
Copy link
Collaborator Author

kobergj commented Feb 3, 2025

Proposal Rejected!

We need to implement patching ocm shares. We can use a frontend only approach: Delete the old share and create a new one.

@kobergj kobergj changed the title Block changing permissions for federated shares Changing permissions for federated shares Feb 3, 2025
@PrajwolAmatya PrajwolAmatya mentioned this issue Feb 5, 2025
Closed
37 tasks
@kobergj kobergj moved this from Qualification to Backlog in Infinite Scale Team Board Feb 5, 2025
@prashant-gurung899 prashant-gurung899 mentioned this issue Feb 6, 2025
Open
16 tasks
@kobergj kobergj mentioned this issue Feb 14, 2025
Merged
@kobergj
Copy link
Collaborator Author

kobergj commented Feb 17, 2025

Current state: We'll try to implement this in the backend because it is less effort.

@kobergj kobergj transferred this issue from owncloud/web Feb 17, 2025
@kobergj kobergj moved this from Backlog to In progress in Infinite Scale Team Board Feb 19, 2025
This was referenced Feb 20, 2025
Closed
Merged
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Feb 24, 2025
@kobergj
Copy link
Collaborator Author

kobergj commented Feb 24, 2025

@2403905 I tried with current master. Changing permissions works (web enables the buttons correctly). But uploading a file fails. Removing and Readding the share works properly. Could you please recheck?

@kobergj kobergj reopened this Feb 24, 2025
@github-project-automation github-project-automation bot moved this from Done to In progress in Infinite Scale Team Board Feb 24, 2025
@2403905
Copy link
Contributor

2403905 commented Feb 25, 2025

@kobergj Thank you for your notice. Firxed in a reva cs3org/reva#5096

@2403905 2403905 closed this as completed Feb 26, 2025
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Feb 26, 2025
@saw-jan saw-jan mentioned this issue Feb 26, 2025
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2403905 2403905

Labels
None yet
Projects
Infinite Scale Team Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[full-ci] Add the ocm notification ShareChangePermission 2403905/ocis
2 participants
@2403905 @kobergj