Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logging on http responses - specifically in error scenarios #12059

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Feb 11, 2025

No description provided.

Copy link

update-docs bot commented Feb 11, 2025

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@erikjv erikjv marked this pull request as draft February 11, 2025 15:14
@erikjv erikjv marked this pull request as ready for review February 14, 2025 13:40
Copy link
Member

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in chat: specifically on download failures it would be great to log the number of received bytes.

@DeepDiver1975 DeepDiver1975 changed the title Add more logging Add more logging on http responses - specifically in error scenarios Feb 18, 2025
@erikjv
Copy link
Collaborator Author

erikjv commented Feb 18, 2025

As noted in chat: specifically on download failures it would be great to log the number of received bytes.

This is done, when the local (file) device is still available.

@DeepDiver1975 DeepDiver1975 enabled auto-merge (squash) February 18, 2025 14:20
@DeepDiver1975 DeepDiver1975 merged commit 3a94ba5 into master Feb 18, 2025
4 checks passed
@DeepDiver1975 DeepDiver1975 deleted the work/more-logging branch February 18, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants