Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center content of the LoginRequiredDialog #11719

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Jun 25, 2024

No description provided.

@erikjv erikjv added this to the Desktop 6.0 milestone Jun 25, 2024
@erikjv erikjv requested a review from TheOneRing June 25, 2024 14:51
@erikjv erikjv self-assigned this Jun 25, 2024
@erikjv
Copy link
Collaborator Author

erikjv commented Jun 25, 2024

Note: it is slightly off-center (to the top), because there is an invisible error label with a retry button. Changing that to be hidden would have the other UI elements "jump" when it is shown, so not a good idea.

@TheOneRing TheOneRing enabled auto-merge (rebase) June 25, 2024 15:06
@erikjv erikjv linked an issue Jun 26, 2024 that may be closed by this pull request
@TheOneRing TheOneRing force-pushed the work/center-LoginRequiredDialog branch from 84b5d4c to 6381608 Compare June 26, 2024 14:24
@TheOneRing TheOneRing disabled auto-merge June 27, 2024 09:04
@TheOneRing TheOneRing merged commit 629d114 into master Jun 27, 2024
5 of 6 checks passed
@TheOneRing TheOneRing deleted the work/center-LoginRequiredDialog branch July 3, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login ui is not vertically centered
2 participants