Work/fix failing winvfs tests (#12088)

Author: erikjv

src/csync/vio/csync_vio_local_win.cpp

@@ -136,6 +136,8 @@ std::unique_ptr<csync_file_stat_t> csync_vio_local_readdir(csync_vio_handle_t *h
 
     if (vfs && vfs->statTypeVirtualFile(file_stat.get(), &handle->ffd)) {
         // all good
+    } else if (handle->ffd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
+        file_stat->type = ItemTypeDirectory;
     } else if (handle->ffd.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) {
         // Detect symlinks, and treat junctions as symlinks too.
         if (handle->ffd.dwReserved0 == IO_REPARSE_TAG_SYMLINK
@@ -150,8 +152,6 @@ std::unique_ptr<csync_file_stat_t> csync_vio_local_readdir(csync_vio_handle_t *h
     } else if (handle->ffd.dwFileAttributes & FILE_ATTRIBUTE_DEVICE
         || handle->ffd.dwFileAttributes & FILE_ATTRIBUTE_OFFLINE) {
         file_stat->type = ItemTypeSkip;
-    } else if (handle->ffd.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) {
-        file_stat->type = ItemTypeDirectory;
     } else {
         file_stat->type = ItemTypeFile;
     }

test/testutils/syncenginetestutils.cpp

@@ -657,7 +657,12 @@ void FakeGetReply::respond()
                 Q_EMIT readyRead();
             }
         }
-        Q_EMIT finished();
+        if (!isFinished()) {
+            // It can happen that this job is cancelled before the full data is read, and the job is aborted. This being the test framework, processing happens
+            // synchronously, so between the signals above and here, the job can get aborted, which emits the finished signal. So do NOT emit it again if
+            // this is the case.
+            Q_EMIT finished();
+        }
     }
 }