fix

Author: TheOneRing

src/gui/accountstate.cpp

@@ -292,13 +292,13 @@ void AccountState::tagLastSuccessfullETagRequest(const QDateTime &tp)
 
 void AccountState::checkConnectivity(bool blockJobs)
 {
-    if (_state != Connected) {
-        setState(Connecting);
-    }
-    qCWarning(lcAccountState) << "checkConnectivity blocking:" << blockJobs;
     if (isSignedOut()) {
         return;
     }
+    qCWarning(lcAccountState) << "checkConnectivity blocking:" << blockJobs;
+    if (_state != Connected) {
+        setState(Connecting);
+    }
     if (_tlsDialog) {
         qCDebug(lcAccountState) << "Skip checkConnectivity, waiting for tls dialog";
         return;
@@ -512,7 +512,9 @@ void AccountState::slotCredentialsFetched()
     qCInfo(lcAccountState) << "Fetched credentials for" << _account->url().toString()
                            << "attempting to connect";
     _waitingForNewCredentials = false;
-    checkConnectivity();
+    if (!isSignedOut()) {
+        checkConnectivity();
+    }
 }
 
 void AccountState::slotCredentialsAsked()

test/testoauth.cpp

@@ -127,7 +127,7 @@ class OAuthTestCase : public QObject
         account->setUrl(sOAuthTestServer);
         // the account seizes ownership over the qnam in account->setCredentials(...) by keeping a shared pointer on it
         // therefore, we should never call fakeAm->setThis(...)
-        account->setCredentials(new FakeCredentials {account.get(), fakeAm });
+        account->setCredentials(new FakeCredentials{account.get(), fakeAm});
         fakeAm->setOverride([this](QNetworkAccessManager::Operation op, const QNetworkRequest &req, QIODevice *device) {
             if (req.url().path().endsWith(QLatin1String(".well-known/openid-configuration"))) {
                 return this->wellKnownReply(op, req);

test/testutils/syncenginetestutils.h

@@ -543,7 +543,7 @@ class FakeCredentials : public OCC::AbstractCredentials
 public:
     FakeCredentials(OCC::Account *account, OCC::AccessManager *am)
         : OCC::AbstractCredentials(account)
-        ,_am { am }
+        , _am{am}
     {
     }