Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Privacy Policy front-matter #4584

Merged
merged 3 commits into from
Feb 21, 2025
Merged

✨ Privacy Policy front-matter #4584

merged 3 commits into from
Feb 21, 2025

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Feb 20, 2025

Adds 2 new features to our about pages

  1. hide-nav in the front-matter, to hide the about page nav
  2. override-title in the front matter, to support existing About pages, and also the upcoming Privacy Policy page (which needs an actual title)

It's hard to imagine a scenario where we'd want one without the other, but given that they were both trivial to add and we won't be making many of them, I figured it was better to be explicit.

To test

Create a gdoc with the following front-matter:

title: My custom about page title
type: about-page
hide-nav: true
override-title: true

@ikesau ikesau requested a review from rakyi February 20, 2025 22:33
@owidbot
Copy link
Contributor

owidbot commented Feb 20, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-privacy-page

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-02-20 22:49:40 UTC
Execution time: 1.21 seconds

Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one small comment. 🙂

@ikesau ikesau merged commit 698d603 into master Feb 21, 2025
27 checks passed
@ikesau ikesau deleted the privacy-page branch February 21, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants