Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 add scrollTo when expanding SiteNavigationToggle on mobile #4579

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented Feb 19, 2025

Adds an effect to scroll the 2 mobile expandable toggles into view when they expand below the viewport, per Marwa's request

site.nav.scrollto.demo.mp4

@ikesau ikesau requested a review from rakyi February 19, 2025 16:18
@ikesau ikesau self-assigned this Feb 19, 2025
@owidbot
Copy link
Contributor

owidbot commented Feb 19, 2025

Quick links (staging server):

Site Dev Site Preview Admin Wizard Docs

Login: ssh owid@staging-site-mobile-nav-scrollto

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2025-02-19 16:34:07 UTC
Execution time: 1.24 seconds

Copy link
Contributor

@rakyi rakyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ikesau ikesau merged commit 9688c7c into master Feb 20, 2025
36 checks passed
@ikesau ikesau deleted the mobile-nav-scrollto branch February 20, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants