🐝 Standardise trailing slashes of URL-like envs #4575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick links (staging server):
Login:
SVG tester:Number of differences (default views): 0 ✅ Edited: 2025-02-19 09:15:20 UTC |
ikesau
approved these changes
Feb 20, 2025
There was a problem hiding this comment.
Looks good!
now I want to urljoin all the things, but that can wait I guess 😬
Co-authored-by: Ike Saunders <11844404+ikesau@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/owid/ops/issues/267, #4480, owid/etl#3889 and https://github.com/owid/ops/issues/266 (the lines of code to fixed issues ratio is unbelievable!).
Remove trailing slash from
DATA_API_URLandETL_WIZARD_URLto be consistent with the rest of variables and ETL envs. Replace string concat byurljointo make sure it still works with old envs.TODO after merging