enhance(mysql): add better indexes for posts_gdocs
table
#4567
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things to the
posts_gdocs
table:type, published, publishedAt
WHERE type = "data-insight" AND published = 1 AND publishedAt <= NOW()
type
published, publishedAt
published
is very commontype
fromVIRTUAL
toSTORED
content ->> "$.authors
"I tested this a bunch and it works well overall, and the new indexes are used.
The only thing I'm not sure about is the addition of the
authors
column, which in theory could cause issues because we're not properly removing it someplace before inserting/updating into the DB. But ifserializePostsGdocsRow
is always used before sending things to the DB, then things will be fine on that end. (Also worth noting that we never had any issues withtype
, which has been a computed column for a long time now.)