🎉 add data insights to algolia pages index #4541
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ikesau
commented
Feb 7, 2025
| @@ -105,15 +106,20 @@ async function generateWordpressRecords( | |||
| const getPostTypeAndImportance = ( | |||
There was a problem hiding this comment.
I wanted to rewrite the PageType type to use the OwidGdocType enum so that it would be compatible with getCanonicalUrl which we now need to be able to link to data insights correctly on the search page, so I had to refactor these 3 functions that each had a pattern match statement.
ikesau
force-pushed
the
data-insights-in-algolia
branch
from
e69cbaf to
1595b38
Compare
ikesau
force-pushed
the
data-insights-in-algolia
branch
from
1595b38 to
79c6628
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4507
Figma
Adds Data Insights as a supported gdoc type in the
indexPagesToAlgoliascript.Most of this PR's diff comes from updating the union type
PageTypeto use theOwidGdocTypeenum so that I could callgetCanonicalURLin the search panel (to correctly prefix the slug with/data-insights/)I also added a slightly complicated
getFirstBlockOfTypeimplementation because my first attempt at this change needed to get both the first image and first paragraph. It's less essential for the PR on the whole, now, but I think will still be a useful util to keep around.