Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db: add index on posts_gdocs.slug column #3713

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

marcelgerber
Copy link
Member

Noticed that we don't have an index for that column yet, and it seems super sensible to have one 👀

@owidbot
Copy link
Contributor

owidbot commented Jun 14, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-db-gdocs-slug-index

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-14 13:35:41 UTC
Execution time: 1.25 seconds

Copy link
Member

@ikesau ikesau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know the perf tradeoffs between fully indexing all 255 characters versus the 100 character substring but in the unlikely event we have collisions I doubt it'll matter much anyway. 👍

@marcelgerber marcelgerber merged commit 32302d7 into master Jun 18, 2024
31 checks passed
@marcelgerber marcelgerber deleted the db-gdocs-slug-index branch June 18, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants