Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (tooltip) fix missing display names #3710

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented Jun 13, 2024

Fixes an issue where the tooltip doesn't show a variable's display name because it contains a new line character at the end (which throws off the regex)

Chart: https://ourworldindata.org/grapher/people-living-in-democracies-autocracies-simplified-lexical?stackMode=relative

image

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @sophiamersmann and the rest of your teammates on Graphite Graphite

@owidbot
Copy link
Contributor

owidbot commented Jun 13, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-tooltip-fix-missing-display-names

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-13 09:05:36 UTC
Execution time: 1.22 seconds

@sophiamersmann sophiamersmann merged commit f5071dd into master Jun 13, 2024
26 checks passed
@sophiamersmann sophiamersmann deleted the tooltip-fix-missing-display-names branch June 13, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants