Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 remove obsolete rebuild table that results in undefined variable #3693

Closed
wants to merge 1 commit into from

Conversation

danyx23
Copy link
Contributor

@danyx23 danyx23 commented Jun 6, 2024

While debugging the chart issue that turned out to be an OOM problem I realized that the admin calls rebuildInputOwidTable explicitly at a point when the data for the newly added indicators isn't yet available. It is called again later, I think throuh a reaction.

This PR thus removes what I think is a redudant and semantically misplaced call.

@owidbot
Copy link
Contributor

owidbot commented Jun 6, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-optimize-admin-indicator-refresh

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-06-06 15:44:55 UTC
Execution time: 1.24 seconds

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found a regression in here, in that changing dimension colors doesn't immediately update the UI any more. It only does so after changing something else about the dimensions.

CleanShot.2024-06-07.at.11.28.03.mp4

Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Jun 22, 2024
@github-actions github-actions bot closed this Jun 26, 2024
@danyx23 danyx23 reopened this Jul 10, 2024
@github-actions github-actions bot removed the stale label Jul 11, 2024
Copy link

This PR has had no activity within the last two weeks. It is considered stale and will be closed in 3 days if no further activity is detected.

@github-actions github-actions bot added the stale label Jul 26, 2024
@github-actions github-actions bot closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants