Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 add commas between sibling ref superscripts #3670

Merged
merged 1 commit into from
May 31, 2024
Merged

🎉 add commas between sibling ref superscripts #3670

merged 1 commit into from
May 31, 2024

Conversation

ikesau
Copy link
Member

@ikesau ikesau commented May 30, 2024

Different browsers render (slightly) differently but I think it's passable

Firefox:
image

Chrome:
image

Safari:
image

@ikesau ikesau requested a review from marcelgerber May 30, 2024 15:38
@ikesau ikesau self-assigned this May 30, 2024
@owidbot
Copy link
Contributor

owidbot commented May 30, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-ref-commas

SVG tester:

Number of differences (default views): 0 ✅
Number of differences (all views): 0 ✅

Edited: 2024-05-30 15:48:07 UTC
Execution time: 1.21 seconds

Copy link
Member

@marcelgerber marcelgerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Yes, agree that the slightly different is totally acceptable. Have tested this in Chrome, Firefox, Safari, and all look good. Go ahead!

@ikesau ikesau merged commit 3db8dfc into master May 31, 2024
28 checks passed
@ikesau ikesau deleted the ref-commas branch May 31, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants