Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (scatter) feedback for selected entities without data / TAS-510 #3663

Merged
merged 1 commit into from
May 30, 2024

Conversation

sophiamersmann
Copy link
Member

@sophiamersmann sophiamersmann commented May 29, 2024

Fixes #3506

Copy link
Member Author

sophiamersmann commented May 29, 2024

@sophiamersmann sophiamersmann changed the title 🐛 (scatter) feedback for selected data without data 🐛 (scatter) feedback for selected data without data / TAS-510 May 29, 2024
Copy link

@sophiamersmann sophiamersmann marked this pull request as ready for review May 29, 2024 09:15
@owidbot
Copy link
Contributor

owidbot commented May 29, 2024

Quick links (staging server):

Site Admin Wizard

Login: ssh owid@staging-site-scatter-no-data-section

SVG tester:

Number of differences (default views): 408 (183027)
Number of differences (all views): 328 (5a4b38)

Edited: 2024-05-29 14:10:47 UTC
Execution time: 1.24 seconds

@sophiamersmann sophiamersmann changed the title 🐛 (scatter) feedback for selected data without data / TAS-510 🐛 (scatter) feedback for selected entities without data / TAS-510 May 29, 2024
@sophiamersmann sophiamersmann force-pushed the scatter-no-data-section branch 2 times, most recently from 7709021 to 830c6b7 Compare May 29, 2024 13:58
Copy link
Member Author

sophiamersmann commented May 30, 2024

Merge activity

@sophiamersmann sophiamersmann force-pushed the scatter-no-data-section branch from 830c6b7 to f13a47e Compare May 30, 2024 07:40
@sophiamersmann sophiamersmann merged commit 0bb7b46 into master May 30, 2024
13 of 15 checks passed
@sophiamersmann sophiamersmann deleted the scatter-no-data-section branch May 30, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScatterPlot: No feedback when an entity is selected that has no data for the current year
2 participants